From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Avoid some copying in psymtab.c
Date: Tue, 31 Mar 2020 18:46:05 +0100 [thread overview]
Message-ID: <93c13abe-c5ca-54e8-90e7-5d0fa171ef13@redhat.com> (raw)
In-Reply-To: <20200320204935.19509-2-tromey@adacore.com>
On 3/20/20 8:49 PM, Tom Tromey wrote:
> + psymtab_search_name search_name (name);
> + lookup_name_info psym_lookup_name (search_name.get (),
> + symbol_name_match_type::FULL);
> +
lookup_name_info has built-in support for psymtab-style symbol
names, with no parameter info. See psym_expand_symtabs_matching:
lookup_name_info lookup_name = lookup_name_in.make_ignore_params ();
I think doing the same in psym_lookup_symbol is likely to work
just the same, and avoid this new class.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2020-03-31 17:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 20:49 [PATCH 0/2] Avoid copying in name lookup Tom Tromey
2020-03-20 20:49 ` [PATCH 1/2] Avoid some copying in psymtab.c Tom Tromey
2020-03-31 17:46 ` Pedro Alves [this message]
2020-03-31 19:35 ` Tom Tromey
2020-03-20 20:49 ` [PATCH 2/2] Avoid copying in lookup_name_info Tom Tromey
2020-03-23 17:51 ` Christian Biesinger
2020-03-31 13:28 ` Tom Tromey
2020-03-31 18:18 ` Pedro Alves
2020-03-31 19:11 ` Tom Tromey
2020-03-31 19:15 ` Tom Tromey
2020-03-31 19:28 ` Pedro Alves
2020-03-31 19:35 ` Tom Tromey
2020-03-31 19:23 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93c13abe-c5ca-54e8-90e7-5d0fa171ef13@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox