From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 78F80385C017 for ; Tue, 31 Mar 2020 17:46:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 78F80385C017 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-309-1eUYIRXCPDWVYW7ySuJdxw-1; Tue, 31 Mar 2020 13:46:08 -0400 X-MC-Unique: 1eUYIRXCPDWVYW7ySuJdxw-1 Received: by mail-wm1-f70.google.com with SMTP id v8so1361300wml.8 for ; Tue, 31 Mar 2020 10:46:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XQSoAbh63+bzVJqTMEyX4P4z49RAMWD2m7jhoFTFaB0=; b=aB2A5HctZenJcUEev3bJbeiP83pzeKxdCRk9GpDixhzD5EX68SCV8cd5XCBxDipQhU AK4ouoqPJ7tDVuldjVL5iYnJmH69pu9PNTH6KJ1rA4MJbHCUnDcagx1kbAYlSJ34mkCS gT7Qx1a62xvkiBwF7oPsHSz05ILqv8CiusfJKpnHDlEaSKQPWByryYEabpe1wo/iNgiZ 7NTGnbohCUoPVkWVLhns0hThqt9cK3kS+xDcYHesw83wGFPtWauxsejsR/kWQgDJMXAO 5K9rP59QR7gmjN47Vn+AOZVLoVy8SfM8XJHYrc49/Yym3nYo4ip2mnbgE4ihv5yj7/FJ sx8w== X-Gm-Message-State: ANhLgQ3Zv+Jgne+FlhVkvikeb+d0yqevsK48aN+TUCoOA9bxwN1+cALJ Lo1Ua/yAqHN02sa8clrz2euCO0kz/8M0vh6vAd5JcOmFUHSj8+HaqcpF1EFCmsNur8bgcMrh6cD zJ0479JqIO668oHDcHuv6rA== X-Received: by 2002:a5d:6a4e:: with SMTP id t14mr16501689wrw.101.1585676767276; Tue, 31 Mar 2020 10:46:07 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvgv3RL4ovOl76DOWYsFu76kRktlvntlKzlqRkU2z71xAkqT7bg8+xTPmn0KQpMx5jEjA4Abg== X-Received: by 2002:a5d:6a4e:: with SMTP id t14mr16501678wrw.101.1585676767105; Tue, 31 Mar 2020 10:46:07 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id u13sm27886804wru.88.2020.03.31.10.46.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2020 10:46:06 -0700 (PDT) Subject: Re: [PATCH 1/2] Avoid some copying in psymtab.c To: Tom Tromey , gdb-patches@sourceware.org References: <20200320204935.19509-1-tromey@adacore.com> <20200320204935.19509-2-tromey@adacore.com> From: Pedro Alves Message-ID: <93c13abe-c5ca-54e8-90e7-5d0fa171ef13@redhat.com> Date: Tue, 31 Mar 2020 18:46:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200320204935.19509-2-tromey@adacore.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2020 17:46:11 -0000 On 3/20/20 8:49 PM, Tom Tromey wrote: > + psymtab_search_name search_name (name); > + lookup_name_info psym_lookup_name (search_name.get (), > + symbol_name_match_type::FULL); > + lookup_name_info has built-in support for psymtab-style symbol names, with no parameter info. See psym_expand_symtabs_matching: lookup_name_info lookup_name = lookup_name_in.make_ignore_params (); I think doing the same in psym_lookup_symbol is likely to work just the same, and avoid this new class. Thanks, Pedro Alves