Re: [PATCH 2/2] Avoid copying in lookup_name_info

[Tom Tromey <tromey@adacore.com>]

>>>>> "Christian" == Christian Biesinger <cbiesinger@google.com> writes:

>> int cmp = (lookup_name.completion_mode ()
>> -            ? strncmp (symbol_search_name, name.c_str (), name.size ())
>> -            : strcmp (symbol_search_name, name.c_str ()));
>> +            ? strncmp (symbol_search_name, name, name_view.size ())
>> +            : strcmp (symbol_search_name, name));

Christian> You can just use symbol_search_name == name_view, since
Christian> gdb::string_view has an overloaded operator==. That way you don't need
Christian> to call c_str() here.

Thanks, I made this change.  I removed "cmp" as well, so now it looks
like:

  if (lookup_name.completion_mode ()
      ? (strncmp (symbol_search_name, name_view.data (),
		  name_view.size ()) == 0)
      : symbol_search_name == name_view)

C++20 has a starts_with method on string view, but we don't have that
yet.

Tom