From: msnyder@sonic.net
To: gdb-patches@sourceware.org
Subject: [OB] Add cleanup, source.c
Date: Thu, 28 Jun 2007 22:35:00 -0000 [thread overview]
Message-ID: <9270.12.7.175.2.1183069663.squirrel@webmail.sonic.net> (raw)
A missed opportunity for cleanup, flagged by Coverity.
I'm cut'and'pasting the patch to avoid my browser turning it into a
binary stream. This may eliminate tabs, but I don't expect anybody
to actually apply this with 'patch'...
2007-06-28 Michael Snyder <msnyder@access-company.com>
* source.c (unset_substitute_path_command): Plug leak (Coverity).
Index: source.c
===================================================================
RCS file: /cvs/src/src/gdb/source.c,v
retrieving revision 1.79
diff -p -r1.79 source.c
*** source.c 24 Jan 2007 00:03:15 -0000 1.79
--- source.c 28 Jun 2007 22:12:36 -0000
*************** unset_substitute_path_command (char *arg
*** 1852,1857 ****
--- 1852,1858 ----
/* This function takes either 0 or 1 argument. */
+ make_cleanup_freeargv (argv);
if (argv != NULL && argv[0] != NULL && argv[1] != NULL)
error (_("Incorrect usage, too many arguments in command"));
next reply other threads:[~2007-06-28 22:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-28 22:35 msnyder [this message]
2007-06-28 22:49 ` Daniel Jacobowitz
2007-06-28 23:12 ` msnyder
[not found] ` <655C3D4066B7954481633935A40BB36F041427@ussunex02.svl.access-company.com>
2007-06-29 0:24 ` Daniel Jacobowitz
2007-06-29 2:05 ` msnyder
2007-06-29 11:37 ` Daniel Jacobowitz
2007-06-29 17:02 ` Joel Brobecker
2007-06-29 20:34 ` Michael Snyder
2007-06-30 10:19 ` Michael Snyder
2007-06-30 14:17 ` Eli Zaretskii
2007-06-30 16:39 ` Michael Snyder
2007-06-30 16:40 ` Daniel Jacobowitz
2007-06-30 18:25 ` Eli Zaretskii
2007-07-03 18:13 ` Jim Blandy
2007-07-04 17:35 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9270.12.7.175.2.1183069663.squirrel@webmail.sonic.net \
--to=msnyder@sonic.net \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox