Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: msnyder@sonic.net,
	Michael Snyder <Michael.Snyder@access-company.com>,
		gdb-patches@sourceware.org
Subject: Re: [OB] Add cleanup, source.c
Date: Fri, 29 Jun 2007 17:02:00 -0000	[thread overview]
Message-ID: <20070629161950.GA3609@adacore.com> (raw)
In-Reply-To: <20070629113407.GA13561@caradoc.them.org>

> >From gdbint.texinfo:
> 
>    Your function should explicitly do or discard the cleanups it
> creates.  Failing to do this leads to non-deterministic behavior since
> the caller will arbitrarily do or discard your functions cleanups.
> This need leads to two common cleanup styles.

Humpf! I think I have contributed loads of patches that do not
follow this advice. I'll be careful in the future, but sometimes
it's not easy. For instance, when you have a function that has
multiple possible exit points...

-- 
Joel


  reply	other threads:[~2007-06-29 16:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-28 22:35 msnyder
2007-06-28 22:49 ` Daniel Jacobowitz
2007-06-28 23:12   ` msnyder
     [not found]   ` <655C3D4066B7954481633935A40BB36F041427@ussunex02.svl.access-company.com>
2007-06-29  0:24     ` Daniel Jacobowitz
2007-06-29  2:05       ` msnyder
2007-06-29 11:37         ` Daniel Jacobowitz
2007-06-29 17:02           ` Joel Brobecker [this message]
2007-06-29 20:34             ` Michael Snyder
2007-06-30 10:19           ` Michael Snyder
2007-06-30 14:17             ` Eli Zaretskii
2007-06-30 16:39               ` Michael Snyder
2007-06-30 16:40                 ` Daniel Jacobowitz
2007-06-30 18:25                 ` Eli Zaretskii
2007-07-03 18:13                   ` Jim Blandy
2007-07-04 17:35                     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070629161950.GA3609@adacore.com \
    --to=brobecker@adacore.com \
    --cc=Michael.Snyder@access-company.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@sonic.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox