From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC 1/6] Unify shell-finding logic
Date: Fri, 28 Sep 2018 21:39:00 -0000 [thread overview]
Message-ID: <913c155ddbaf7302ceb68d44bc41b32a@polymtl.ca> (raw)
In-Reply-To: <20180926111130.18956-2-tom@tromey.com>
On 2018-09-26 07:11, Tom Tromey wrote:
> diff --git a/gdb/procfs.c b/gdb/procfs.c
> index 6ffe569e69..ca381a71ae 100644
> --- a/gdb/procfs.c
> +++ b/gdb/procfs.c
> @@ -3035,11 +3035,11 @@ procfs_target::create_inferior (const char
> *exec_file,
> const std::string &allargs,
> char **env, int from_tty)
> {
> - char *shell_file = getenv ("SHELL");
> + const char *shell_file = get_shell ();
> char *tryname;
> int pid;
>
> - if (shell_file != NULL && strchr (shell_file, '/') == NULL)
> + if (strchr (shell_file, '/') == NULL)
At first I thought this would change the behavior here, but I think it's
fine. If SHELL is not defined, we used to pass NULL to fork_inferior,
and it would fall back to /bin/sh. Now, the fallback just happens
sooner. So this looks good, I think this patch can go in by itself.
Thanks,
Simon
next prev parent reply other threads:[~2018-09-28 21:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 11:12 [RFC 0/6] A different approach to startup-with-shell on macOS Tom Tromey
2018-09-26 11:11 ` [RFC 1/6] Unify shell-finding logic Tom Tromey
2018-09-28 21:39 ` Simon Marchi [this message]
2018-09-26 11:12 ` [RFC 4/6] Use mkostemp, not mkstemp Tom Tromey
2018-09-29 3:09 ` Simon Marchi
2018-09-29 12:49 ` Tom Tromey
2018-09-29 14:04 ` Simon Marchi
2018-09-26 11:12 ` [RFC 2/6] Move make_temp_filename to common/pathstuff.c Tom Tromey
2018-09-26 11:12 ` [RFC 5/6] Do not reopen temporary files Tom Tromey
2018-09-26 14:12 ` Eli Zaretskii
2018-09-26 21:44 ` Tom Tromey
2018-09-29 3:22 ` Simon Marchi
2018-10-01 9:15 ` Tom Tromey
2018-09-26 11:20 ` [RFC 6/6] Cache a copy of the user's shell on macOS Tom Tromey
2018-09-29 3:37 ` Simon Marchi
2018-10-01 19:27 ` Tom Tromey
2018-10-01 19:31 ` Simon Marchi
2018-09-26 11:20 ` [RFC 3/6] Move mkdir_recursive to common/filestuff.c Tom Tromey
2018-09-26 22:11 ` Tom Tromey
2018-09-26 23:16 ` Tom Tromey
2018-09-28 21:21 ` [RFC 0/6] A different approach to startup-with-shell on macOS Simon Marchi
2018-09-29 18:43 ` Pedro Alves
2018-09-29 19:50 ` Simon Marchi
2018-09-29 20:38 ` Pedro Alves
2018-10-01 9:12 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=913c155ddbaf7302ceb68d44bc41b32a@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox