From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC 5/6] Do not reopen temporary files
Date: Wed, 26 Sep 2018 14:12:00 -0000 [thread overview]
Message-ID: <83ftxw8i1g.fsf@gnu.org> (raw)
In-Reply-To: <20180926111130.18956-6-tom@tromey.com> (message from Tom Tromey on Wed, 26 Sep 2018 05:11:29 -0600)
> From: Tom Tromey <tom@tromey.com>
> Cc: Tom Tromey <tom@tromey.com>
> Date: Wed, 26 Sep 2018 05:11:29 -0600
>
> The current callers of mkostemp close the file descriptor and then
> re-open it with fopen. It seemed better to me to continue to use the
> already-opened file descriptor, so this patch rearranges the code a
> little in order to do so. It takes care to ensure that the files are
> only unlinked after the file descriptor in question is closed, as
> before.
Bother...
> - FILE *out_file = gdb_fopen_cloexec (filename_temp.data (), "wb").release ();
> + gdb_file_up out_file = out_file_fd.to_file ("wb");
There's a known bug in the MS-Windows (thus MinGW) implementation of
'fdopen': it ignores the 'b' and 't' flags. So the preceding call to
'open' must itself specify the O_BINARY flag, or else this replacement
will introduce a subtle bug.
Thanks.
next prev parent reply other threads:[~2018-09-26 14:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 11:12 [RFC 0/6] A different approach to startup-with-shell on macOS Tom Tromey
2018-09-26 11:11 ` [RFC 1/6] Unify shell-finding logic Tom Tromey
2018-09-28 21:39 ` Simon Marchi
2018-09-26 11:12 ` [RFC 5/6] Do not reopen temporary files Tom Tromey
2018-09-26 14:12 ` Eli Zaretskii [this message]
2018-09-26 21:44 ` Tom Tromey
2018-09-29 3:22 ` Simon Marchi
2018-10-01 9:15 ` Tom Tromey
2018-09-26 11:12 ` [RFC 4/6] Use mkostemp, not mkstemp Tom Tromey
2018-09-29 3:09 ` Simon Marchi
2018-09-29 12:49 ` Tom Tromey
2018-09-29 14:04 ` Simon Marchi
2018-09-26 11:12 ` [RFC 2/6] Move make_temp_filename to common/pathstuff.c Tom Tromey
2018-09-26 11:20 ` [RFC 6/6] Cache a copy of the user's shell on macOS Tom Tromey
2018-09-29 3:37 ` Simon Marchi
2018-10-01 19:27 ` Tom Tromey
2018-10-01 19:31 ` Simon Marchi
2018-09-26 11:20 ` [RFC 3/6] Move mkdir_recursive to common/filestuff.c Tom Tromey
2018-09-26 22:11 ` Tom Tromey
2018-09-26 23:16 ` Tom Tromey
2018-09-28 21:21 ` [RFC 0/6] A different approach to startup-with-shell on macOS Simon Marchi
2018-09-29 18:43 ` Pedro Alves
2018-09-29 19:50 ` Simon Marchi
2018-09-29 20:38 ` Pedro Alves
2018-10-01 9:12 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ftxw8i1g.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox