From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9026 invoked by alias); 28 Sep 2018 21:39:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8984 invoked by uid 89); 28 Sep 2018 21:39:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Sep 2018 21:39:55 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w8SLdmLf011972 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 28 Sep 2018 17:39:53 -0400 Received: by simark.ca (Postfix, from userid 112) id A84F71E987; Fri, 28 Sep 2018 17:39:48 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id AA63E1E186; Fri, 28 Sep 2018 17:39:47 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 28 Sep 2018 21:39:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFC 1/6] Unify shell-finding logic In-Reply-To: <20180926111130.18956-2-tom@tromey.com> References: <20180926111130.18956-1-tom@tromey.com> <20180926111130.18956-2-tom@tromey.com> Message-ID: <913c155ddbaf7302ceb68d44bc41b32a@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00924.txt.bz2 On 2018-09-26 07:11, Tom Tromey wrote: > diff --git a/gdb/procfs.c b/gdb/procfs.c > index 6ffe569e69..ca381a71ae 100644 > --- a/gdb/procfs.c > +++ b/gdb/procfs.c > @@ -3035,11 +3035,11 @@ procfs_target::create_inferior (const char > *exec_file, > const std::string &allargs, > char **env, int from_tty) > { > - char *shell_file = getenv ("SHELL"); > + const char *shell_file = get_shell (); > char *tryname; > int pid; > > - if (shell_file != NULL && strchr (shell_file, '/') == NULL) > + if (strchr (shell_file, '/') == NULL) At first I thought this would change the behavior here, but I think it's fine. If SHELL is not defined, we used to pass NULL to fork_inferior, and it would fall back to /bin/sh. Now, the fallback just happens sooner. So this looks good, I think this patch can go in by itself. Thanks, Simon