Re: [PATCH v1 4/8] gdb support: add index_type to array_view for documentation purpose

[Pedro Alves <pedro@palves.net>]

On 2026-07-03 19:58, Matthieu Longo wrote:
> The semantic of slice (size_type start, size_type size) might be
> slightly ambiguous if the variable names are omitted. Making the
> index type different from the size type removes this ambiguity.
> This change is purely cosmetic.

You've changed the type from size_t (unsigned) to ptrdiff_t (signed).  That's not cosmetic.

The code was using size_type (and size_t) for indexing, as that's what standard containers
use.  There's no std::vector::index_type, etc.

Also this:

 > -void copy (gdb::array_view<U> src, gdb::array_view<T> dest)
 > +void copy (array_view<U> src, array_view<T> dest)

... seem unrelated.