[PATCH v1 4/8] gdb support: add index_type to array_view for documentation purpose

[Matthieu Longo <matthieu.longo@arm.com>]

The semantic of slice (size_type start, size_type size) might be
slightly ambiguous if the variable names are omitted. Making the
index type different from the size type removes this ambiguity.
This change is purely cosmetic.
---
 gdbsupport/array-view.h | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/gdbsupport/array-view.h b/gdbsupport/array-view.h
index 8431d7f5add..e7baea728d4 100644
--- a/gdbsupport/array-view.h
+++ b/gdbsupport/array-view.h
@@ -87,6 +87,7 @@ class array_view
   using value_type = T;
   using reference = T &;
   using const_reference = const T &;
+  using index_type = ptrdiff_t;
   using size_type = size_t;
   using const_iterator = const T *;
   using iterator = T *;
@@ -165,14 +166,14 @@ class array_view
   constexpr iterator end () const noexcept { return m_array + m_size; }
   constexpr const_iterator cend () const noexcept { return m_array + m_size; }
 
-  constexpr reference operator[] (size_t index) noexcept
+  constexpr reference operator[] (index_type index) noexcept
   {
 #if defined(_GLIBCXX_DEBUG)
     gdb_assert (index < m_size);
 #endif
     return m_array[index];
   }
-  constexpr const_reference operator[] (size_t index) const noexcept
+  constexpr const_reference operator[] (index_type index) const noexcept
   {
 #if defined(_GLIBCXX_DEBUG)
     gdb_assert (index < m_size);
@@ -187,7 +188,7 @@ class array_view
 
   /* Return a new array view over SIZE elements starting at START.  */
   [[nodiscard]]
-  constexpr array_view<T> slice (size_type start, size_type size) const noexcept
+  constexpr array_view<T> slice (index_type start, size_type size) const noexcept
   {
 #if defined(_GLIBCXX_DEBUG)
     gdb_assert (start + size <= m_size);
@@ -198,7 +199,7 @@ class array_view
   /* Return a new array view over all the elements after START,
      inclusive.  */
   [[nodiscard]]
-  constexpr array_view<T> slice (size_type start) const noexcept
+  constexpr array_view<T> slice (index_type start) const noexcept
   {
 #if defined(_GLIBCXX_DEBUG)
     gdb_assert (start <= m_size);
@@ -216,7 +217,7 @@ class array_view
    The two array views must have the same length.  */
 
 template <typename U, typename T>
-void copy (gdb::array_view<U> src, gdb::array_view<T> dest)
+void copy (array_view<U> src, array_view<T> dest)
 {
   gdb_assert (dest.size () == src.size ());
   if (dest.data () < src.data ())
-- 
2.55.0