From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CjWSKN0TSGobKSQAWB0awg (envelope-from ) for ; Fri, 03 Jul 2026 15:56:13 -0400 Received: by simark.ca (Postfix, from userid 112) id 944461E098; Fri, 03 Jul 2026 15:56:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F1B3B1E024 for ; Fri, 03 Jul 2026 15:56:12 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1C6ED4BA2E3E for ; Fri, 3 Jul 2026 19:56:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1C6ED4BA2E3E Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by sourceware.org (Postfix) with ESMTPS id 3E0164BA540B for ; Fri, 3 Jul 2026 19:55:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E0164BA540B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3E0164BA540B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783108548; cv=none; b=E41sQMAcW2ZP2x4AaXUGzLEKkJqsMcfcqAWpjqHq1NWEmxxP/XooxiHnUYSHNwoPalnPS21Olh11Soqmkl5H6tZkcRyWpkJinDd/DmIAfV/ya91bxn8UQLm7iVDC71Ucrr8U8XIZahh49V+QBjB4yzY95lcC/AHNnGWKqJbAq5A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783108548; c=relaxed/simple; bh=04yEPrDdQ0xvVOsUslztgVCnvpRXeuoDMOPcOBPE2Z4=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=xBcC/GaoA6bXZIjPu8U9Xs7jffyRQopWfa1v+iky3EZrHMoIgtXeiLAnFLLD8pm4m6mmzcC+AlaKPTTzXHM49yV24uBb2pHO6FRlIGqeb4ZiuBtJOz6EBpOr2nLig6cYprS6EZgek5yzzMbI5/+MQD9hrdAQZloa+7VJ9eox7sI= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3E0164BA540B Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-493c1950518so10485425e9.1 for ; Fri, 03 Jul 2026 12:55:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783108547; x=1783713347; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YsebiNvTP7AjdFXh29BOw/B8gUsH7NJVrzM4Sv70u4U=; b=CJ4V6hrSejrTWINYPXQ1pylflONnnAYa9PAp/6MBxoVk2KDnc1HinfpICFVtXUFJ/d Uf7vU34tnVmmR8GgnFbCXz6gYKr4H6+tfPp1TFdw74FjZ/IeA08iZcC4Xqs4YRCrCVxw 1CYLekBLRqJU0h/XlX6wIVjptefH+JH81rIM9vcnT/mCWqRSw/32Ue/TgMQHFbw4qa3c I2F6BfSOQeXiGq5DPcrHZ2heaHEEPHq6Z3c+POl8MbXzPffdxHeE2Xqcnk6SsJiTLeUO aTfKsWx2aC0RYIFiSXntCriNX7eYh2L90jIGjmDxpBzkibQNTe8NF4ggagyv3331nK/+ qLBQ== X-Forwarded-Encrypted: i=1; AFNElJ8oicnusMMVKifirpdT8gGFwynlkV+6wbGuEnc6y1pAs6N5JuBxtf53A8Zw5HWWeQSb/dLCb4mjBnQyTw==@sourceware.org X-Gm-Message-State: AOJu0YyIHgfh9fJFS+9m27rjE/nhK4LB01IHMjAtgSsG0uwJYkpnlUrb xDERCVGCGng6FkVg6Y9WQXqNBmAyBqkKvU3BiHhgze/dbzcjaa3vKrTR X-Gm-Gg: AfdE7cno4SguDVirt7sBy0OAxy69jE1lPnkD+z6JL9WQVWq0ygdfQVmgeOajWP8effm UakYIErHWcOf+oxuV5aucVkrTPNXVEEi7cSRJig8K5aPruBuHuXWXunTSYGJ25sgUru8RF65NfX gNi0Be1yVlszhqKaniODaujWJQ5qbqgWBWRjDGWctkQ6E3gdrRZOIBj2M9rFRvMUpF/gTL8OVu9 tVPg6VMa1TNSgyyO9aeUzzLuJjG8ePOH+rdmKd+yAb4KxuFgYcDapHt8bFsv8B+PmwV9AAIqYay vS9uVUpAlgbHlxdCugLC7YIQC3un51S8dq7H+Z+mBPSDdinOXHszmJB7IXxqm0OyMC4qsf6vMrX e+Nq6M3q39p7yXZ8OiBflhADffI38kJiS2Upt/XVyaD5xuNBGiJ2GFqtYB2X3h86qRgBVNhu/cB DznhXIxwGpfVaEp3I5ocxxcejXRi/quG70wwxguCvSASLvfpjgVkLQlhw= X-Received: by 2002:a05:600c:c171:b0:490:ae36:4835 with SMTP id 5b1f17b1804b1-493c9b82d92mr72347985e9.17.1783108547042; Fri, 03 Jul 2026 12:55:47 -0700 (PDT) Received: from ?IPV6:2001:8a0:fac2:7700:16ec:3248:805b:c97a? ([2001:8a0:fac2:7700:16ec:3248:805b:c97a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa039ae4fsm1744645f8f.18.2026.07.03.12.55.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2026 12:55:46 -0700 (PDT) Message-ID: <90d5b118-fa2a-4c6e-91c3-48bd9deaf27f@palves.net> Date: Fri, 3 Jul 2026 20:55:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 4/8] gdb support: add index_type to array_view for documentation purpose To: Matthieu Longo , gdb-patches@sourceware.org Cc: Luis Machado , Luis Machado , Andrew Burgess References: <20260703185853.450440-1-matthieu.longo@arm.com> <20260703185853.450440-5-matthieu.longo@arm.com> From: Pedro Alves Content-Language: en-US In-Reply-To: <20260703185853.450440-5-matthieu.longo@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-07-03 19:58, Matthieu Longo wrote: > The semantic of slice (size_type start, size_type size) might be > slightly ambiguous if the variable names are omitted. Making the > index type different from the size type removes this ambiguity. > This change is purely cosmetic. You've changed the type from size_t (unsigned) to ptrdiff_t (signed). That's not cosmetic. The code was using size_type (and size_t) for indexing, as that's what standard containers use. There's no std::vector::index_type, etc. Also this: > -void copy (gdb::array_view src, gdb::array_view dest) > +void copy (array_view src, array_view dest) ... seem unrelated.