From: Kai Tietz <ktietz70@googlemail.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Kai Tietz <Kai.Tietz@onevision.com>
Subject: Re: [patch]: Fix windows x64 build
Date: Wed, 11 Feb 2009 14:40:00 -0000 [thread overview]
Message-ID: <90baa01f0902110638i36bf8082n952e92524b87a213@mail.gmail.com> (raw)
In-Reply-To: <200902111435.28843.pedro@codesourcery.com>
2009/2/11 Pedro Alves <pedro@codesourcery.com>:
> On Wednesday 11 February 2009 14:21:40, Kai Tietz wrote:
>> Hello,
>>
>> I noticed that building of w64 was broken by a warning in gdbarch.c by
>> casting a pointer to long type.
>>
>> ChangeLog
>>
>> 2009-02-11 Kai Tietz <kai,tietz@onevision.com>
>>
>> * gdbarch.c (gdbarch_dump): Cast via size_t to long.
>>
>> Is this patch ok to apply?
>
> Nope, sorry, this is a generated file, see gdbarch.sh. We need to regenerate
> gdbarch.c and gdbarch.h whenever gdbarch.sh is changed, but looks like I forgot
> to regenerate it to pick up the changes that make this use
> host_address_to_string instead, since long is wrong for Win64.
>
> Sorry about that. It should be fixed now. gdbarch.h didn't change.
>
> --
> Pedro Alves
>
Patch works for me.
Thanks,
Kai
--
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination
prev parent reply other threads:[~2009-02-11 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 14:21 Kai Tietz
2009-02-11 14:35 ` Pedro Alves
2009-02-11 14:40 ` Kai Tietz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90baa01f0902110638i36bf8082n952e92524b87a213@mail.gmail.com \
--to=ktietz70@googlemail.com \
--cc=Kai.Tietz@onevision.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox