From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Kai Tietz <Kai.Tietz@onevision.com>
Subject: Re: [patch]: Fix windows x64 build
Date: Wed, 11 Feb 2009 14:35:00 -0000 [thread overview]
Message-ID: <200902111435.28843.pedro@codesourcery.com> (raw)
In-Reply-To: <OF8ECADAD5.B0A0B284-ONC125755A.004E836A-C125755A.004EDF57@onevision.de>
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
On Wednesday 11 February 2009 14:21:40, Kai Tietz wrote:
> Hello,
>
> I noticed that building of w64 was broken by a warning in gdbarch.c by
> casting a pointer to long type.
>
> ChangeLog
>
> 2009-02-11 Kai Tietz <kai,tietz@onevision.com>
>
> * gdbarch.c (gdbarch_dump): Cast via size_t to long.
>
> Is this patch ok to apply?
Nope, sorry, this is a generated file, see gdbarch.sh. We need to regenerate
gdbarch.c and gdbarch.h whenever gdbarch.sh is changed, but looks like I forgot
to regenerate it to pick up the changes that make this use
host_address_to_string instead, since long is wrong for Win64.
Sorry about that. It should be fixed now. gdbarch.h didn't change.
--
Pedro Alves
[-- Attachment #2: regen.diff --]
[-- Type: text/x-diff, Size: 1027 bytes --]
2009-02-11 Pedro Alves <pedro@codesourcery.com>
* gdbarch.c: Regenerate.
---
gdb/gdbarch.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: src/gdb/gdbarch.c
===================================================================
--- src.orig/gdb/gdbarch.c 2009-02-11 14:27:48.000000000 +0000
+++ src/gdb/gdbarch.c 2009-02-11 14:27:23.000000000 +0000
@@ -841,8 +841,8 @@ gdbarch_dump (struct gdbarch *gdbarch, s
"gdbarch_dump: gdbarch_get_siginfo_type_p() = %d\n",
gdbarch_get_siginfo_type_p (gdbarch));
fprintf_unfiltered (file,
- "gdbarch_dump: get_siginfo_type = <0x%lx>\n",
- (long) gdbarch->get_siginfo_type);
+ "gdbarch_dump: get_siginfo_type = <%s>\n",
+ host_address_to_string (gdbarch->get_siginfo_type));
fprintf_unfiltered (file,
"gdbarch_dump: has_global_solist = %s\n",
plongest (gdbarch->has_global_solist));
next prev parent reply other threads:[~2009-02-11 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 14:21 Kai Tietz
2009-02-11 14:35 ` Pedro Alves [this message]
2009-02-11 14:40 ` Kai Tietz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902111435.28843.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=Kai.Tietz@onevision.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox