From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14434 invoked by alias); 11 Feb 2009 14:35:41 -0000 Received: (qmail 14424 invoked by uid 22791); 11 Feb 2009 14:35:40 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Feb 2009 14:35:34 +0000 Received: (qmail 28323 invoked from network); 11 Feb 2009 14:35:30 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 11 Feb 2009 14:35:30 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch]: Fix windows x64 build Date: Wed, 11 Feb 2009 14:35:00 -0000 User-Agent: KMail/1.9.10 Cc: Kai Tietz References: In-Reply-To: MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_wIukJKf0c0uD9ZF" Message-Id: <200902111435.28843.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00237.txt.bz2 --Boundary-00=_wIukJKf0c0uD9ZF Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 711 On Wednesday 11 February 2009 14:21:40, Kai Tietz wrote: > Hello, > > I noticed that building of w64 was broken by a warning in gdbarch.c by > casting a pointer to long type. > > ChangeLog > > 2009-02-11 Kai Tietz > > * gdbarch.c (gdbarch_dump): Cast via size_t to long. > > Is this patch ok to apply? Nope, sorry, this is a generated file, see gdbarch.sh. We need to regenerate gdbarch.c and gdbarch.h whenever gdbarch.sh is changed, but looks like I forgot to regenerate it to pick up the changes that make this use host_address_to_string instead, since long is wrong for Win64. Sorry about that. It should be fixed now. gdbarch.h didn't change. -- Pedro Alves --Boundary-00=_wIukJKf0c0uD9ZF Content-Type: text/x-diff; charset="iso 8859-15"; name="regen.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="regen.diff" Content-length: 1027 2009-02-11 Pedro Alves * gdbarch.c: Regenerate. --- gdb/gdbarch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: src/gdb/gdbarch.c =================================================================== --- src.orig/gdb/gdbarch.c 2009-02-11 14:27:48.000000000 +0000 +++ src/gdb/gdbarch.c 2009-02-11 14:27:23.000000000 +0000 @@ -841,8 +841,8 @@ gdbarch_dump (struct gdbarch *gdbarch, s "gdbarch_dump: gdbarch_get_siginfo_type_p() = %d\n", gdbarch_get_siginfo_type_p (gdbarch)); fprintf_unfiltered (file, - "gdbarch_dump: get_siginfo_type = <0x%lx>\n", - (long) gdbarch->get_siginfo_type); + "gdbarch_dump: get_siginfo_type = <%s>\n", + host_address_to_string (gdbarch->get_siginfo_type)); fprintf_unfiltered (file, "gdbarch_dump: has_global_solist = %s\n", plongest (gdbarch->has_global_solist)); --Boundary-00=_wIukJKf0c0uD9ZF--