From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16974 invoked by alias); 11 Feb 2009 14:40:28 -0000 Received: (qmail 16966 invoked by uid 22791); 11 Feb 2009 14:40:27 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-fx0-f18.google.com (HELO mail-fx0-f18.google.com) (209.85.220.18) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Feb 2009 14:40:05 +0000 Received: by fxm11 with SMTP id 11so476664fxm.0 for ; Wed, 11 Feb 2009 06:40:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.181.21.2 with SMTP id y2mr294291bki.144.1234363093907; Wed, 11 Feb 2009 06:38:13 -0800 (PST) In-Reply-To: <200902111435.28843.pedro@codesourcery.com> References: <200902111435.28843.pedro@codesourcery.com> Date: Wed, 11 Feb 2009 14:40:00 -0000 Message-ID: <90baa01f0902110638i36bf8082n952e92524b87a213@mail.gmail.com> Subject: Re: [patch]: Fix windows x64 build From: Kai Tietz To: Pedro Alves Cc: gdb-patches@sourceware.org, Kai Tietz Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00238.txt.bz2 2009/2/11 Pedro Alves : > On Wednesday 11 February 2009 14:21:40, Kai Tietz wrote: >> Hello, >> >> I noticed that building of w64 was broken by a warning in gdbarch.c by >> casting a pointer to long type. >> >> ChangeLog >> >> 2009-02-11 Kai Tietz >> >> * gdbarch.c (gdbarch_dump): Cast via size_t to long. >> >> Is this patch ok to apply? > > Nope, sorry, this is a generated file, see gdbarch.sh. We need to regenerate > gdbarch.c and gdbarch.h whenever gdbarch.sh is changed, but looks like I forgot > to regenerate it to pick up the changes that make this use > host_address_to_string instead, since long is wrong for Win64. > > Sorry about that. It should be fixed now. gdbarch.h didn't change. > > -- > Pedro Alves > Patch works for me. Thanks, Kai -- | (\_/) This is Bunny. Copy and paste | (='.'=) Bunny into your signature to help | (")_(") him gain world domination