Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>,
	       John Marshall <John.W.Marshall@glasgow.ac.uk>,
	       gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix build failure with macOS bison
Date: Tue, 08 Jan 2019 17:46:00 -0000	[thread overview]
Message-ID: <9076afd60014faef6eb75aa8040fab09@polymtl.ca> (raw)
In-Reply-To: <87va2zzz6d.fsf@tromey.com>

On 2019-01-07 21:00, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
> 
> Simon> Since other files already use the name DOLLAR_VARIABLE, I
> suggest using it
> Simon> too.  I went a bit further and changed other .y files too, so 
> they use a
> Simon> consistent name.
> 
> Simon> Tom, are you ok with this?
> 
> Yes, completely.  Thanks for doing this.

Pushed, thanks.

Simon


  reply	other threads:[~2019-01-08 17:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-07 15:38 John Marshall
2019-01-07 16:14 ` John Marshall
2019-01-07 22:09   ` Simon Marchi
2019-01-08  2:00     ` Tom Tromey
2019-01-08 17:46       ` Simon Marchi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-01-06 16:49 Tom Tromey
2019-01-06 16:50 ` Tom Tromey
2019-01-06 16:53   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9076afd60014faef6eb75aa8040fab09@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=John.W.Marshall@glasgow.ac.uk \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox