Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org, Simon Marchi <simark@simark.ca>
Subject: Re: [PATCH] Fix build failure with macOS bison
Date: Sun, 06 Jan 2019 16:50:00 -0000	[thread overview]
Message-ID: <87pnt9zq5t.fsf@tromey.com> (raw)
In-Reply-To: <20190106164911.22546-1-tom@tromey.com> (Tom Tromey's message of	"Sun, 6 Jan 2019 09:49:11 -0700")

>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:

Tom> PR gdb/24060 points out a compilation failure of the C parser when it
Tom> is built using the macOS system bison.  The bug is a name clash
Tom> between the VARIABLE token name and the VARIABLE enumerator in
Tom> ui-out.h.

Tom> This patch renames VARIABLE in c-exp.y to avoid the clash.  I chose to
Tom> rename this identifier because it was the more localized change.

Tom> gdb/ChangeLog
Tom> 2019-01-06  Tom Tromey  <tom@tromey.com>

Tom> 	PR gdb/24060:
Tom> 	* c-exp.y (CONV_VAR): Rename from VARIABLE.

Simon -- I can't readily try this patch on macOS right now, so I was
hoping you could.

Tom


  reply	other threads:[~2019-01-06 16:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-06 16:49 Tom Tromey
2019-01-06 16:50 ` Tom Tromey [this message]
2019-01-06 16:53   ` Simon Marchi
2019-01-07 15:38 John Marshall
2019-01-07 16:14 ` John Marshall
2019-01-07 22:09   ` Simon Marchi
2019-01-08  2:00     ` Tom Tromey
2019-01-08 17:46       ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnt9zq5t.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox