From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 924 invoked by alias); 6 Jan 2019 16:50:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 912 invoked by uid 89); 6 Jan 2019 16:50:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:698, hoping, H*Ad:D*ca X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.46.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 06 Jan 2019 16:50:24 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 3331C400CF5C1 for ; Sun, 6 Jan 2019 10:50:23 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id gBd1gHRCY2PzOgBd1gwfAd; Sun, 06 Jan 2019 10:50:23 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zy1FUmOlxUqShHA9oRXmor97lTKpUOKtEI90xd2IzPI=; b=jkTAy+W96IjfCTP7TUmzv75+H2 4bUfD5LkGKceOiz6JH0+5FniSdU86dEqgAFQc09PoTlZIEEf2/H5M5tfWMdY8h+keYPJ7AWPDKNzD FuoKBSBfm2HbLjGe+Rifmwwo0; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:48214 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1ggBd0-000WoR-Vt; Sun, 06 Jan 2019 10:50:23 -0600 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH] Fix build failure with macOS bison References: <20190106164911.22546-1-tom@tromey.com> Date: Sun, 06 Jan 2019 16:50:00 -0000 In-Reply-To: <20190106164911.22546-1-tom@tromey.com> (Tom Tromey's message of "Sun, 6 Jan 2019 09:49:11 -0700") Message-ID: <87pnt9zq5t.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-01/txt/msg00090.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> PR gdb/24060 points out a compilation failure of the C parser when it Tom> is built using the macOS system bison. The bug is a name clash Tom> between the VARIABLE token name and the VARIABLE enumerator in Tom> ui-out.h. Tom> This patch renames VARIABLE in c-exp.y to avoid the clash. I chose to Tom> rename this identifier because it was the more localized change. Tom> gdb/ChangeLog Tom> 2019-01-06 Tom Tromey Tom> PR gdb/24060: Tom> * c-exp.y (CONV_VAR): Rename from VARIABLE. Simon -- I can't readily try this patch on macOS right now, so I was hoping you could. Tom