From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-153260-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 120743 invoked by alias); 8 Jan 2019 17:46:44 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 120718 invoked by uid 89); 8 Jan 2019 17:46:43 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=bison
X-HELO: smtp.polymtl.ca
Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 Jan 2019 17:46:41 +0000
Received: from simark.ca (simark.ca [158.69.221.121])	(authenticated bits=0)	by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x08HkZCY029238	(version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)	for <gdb-patches@sourceware.org>; Tue, 8 Jan 2019 12:46:40 -0500
Received: by simark.ca (Postfix, from userid 112)	id 18C6E1E7B7; Tue,  8 Jan 2019 12:46:35 -0500 (EST)
Received: from simark.ca (localhost [127.0.0.1])	by simark.ca (Postfix) with ESMTP id BA7041E4C0;	Tue,  8 Jan 2019 12:46:33 -0500 (EST)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Tue, 08 Jan 2019 17:46:00 -0000
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>,        John Marshall <John.W.Marshall@glasgow.ac.uk>,        gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix build failure with macOS bison
In-Reply-To: <87va2zzz6d.fsf@tromey.com>
References: <12BBB509-646E-4140-ACB8-856A453E5646@glasgow.ac.uk> <051D67D6-A7D8-4A6F-A54E-501051C2D4BA@glasgow.ac.uk> <7dd4f695-ec03-5cd7-47ec-7caf1a5f4414@ericsson.com> <87va2zzz6d.fsf@tromey.com>
Message-ID: <9076afd60014faef6eb75aa8040fab09@polymtl.ca>
X-Sender: simon.marchi@polymtl.ca
User-Agent: Roundcube Webmail/1.3.6
X-IsSubscribed: yes
X-SW-Source: 2019-01/txt/msg00150.txt.bz2

On 2019-01-07 21:00, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
> 
> Simon> Since other files already use the name DOLLAR_VARIABLE, I
> suggest using it
> Simon> too.  I went a bit further and changed other .y files too, so 
> they use a
> Simon> consistent name.
> 
> Simon> Tom, are you ok with this?
> 
> Yes, completely.  Thanks for doing this.

Pushed, thanks.

Simon