From: Simon Marchi <simark@simark.ca>
To: Eli Zaretskii <eliz@gnu.org>, Tom Tromey <tom@tromey.com>
Cc: midenok@gmail.com, gdb@sourceware.org, gdb-patches@sourceware.org
Subject: Re: GDB 9 TUI mode broken
Date: Sat, 22 Feb 2020 15:55:00 -0000 [thread overview]
Message-ID: <8f41a400-0c17-4fec-3de1-0bd93423298f@simark.ca> (raw)
In-Reply-To: <83mu9aj1pj.fsf@gnu.org>
On 2020-02-22 6:33 a.m., Eli Zaretskii wrote:
>> Date: Mon, 17 Feb 2020 19:46:36 +0200
>> From: Eli Zaretskii <eliz@gnu.org>
>> CC: gdb@sourceware.org
>>
>>> From: Aleksey Midenkov <midenok@gmail.com>
>>> Date: Mon, 17 Feb 2020 19:26:07 +0300
>>>
>>> Now the window molders away after `winheight src +8` command.
>>
>> This looks like a bug, and is probably unrelated to colors. Suggest
>> to make a bug report.
>
> The patch below seems to fix some of the problem, but not all of it:
> the position of the status line (the one that shows the process
> information) is not updated correctly.
>
> Tom, where's the position update of the status line supposed to be
> handled?
>
> And btw, the meaning of the 'locator' object in tui_adjust_win_heights
> is unclear: to which window does it pertain, and what is the
> significance of this line:
>
> TUI_CMD_WIN->origin.y = locator->origin.y + 1;
>
> I think we could use some additional comments in tui-stack.c or
> tui-stack.h, to explain what is the meaning and expected use of
> tui_locator_window.
The locator window is the line that sits between the source windows and the command
line's window (in the TUI's source layout). It displays information such as current
thread id, current line and current PC.
I learned this watching Tom's excellent FOSDEM presentation, here :)
https://fosdem.org/2020/schedule/event/debugging_gdb_tui/
Simon
next prev parent reply other threads:[~2020-02-22 15:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAF8BazBni=TZWTc5fbpdHU5bv1eM=24xpML46GCC2u4pFTkSAw@mail.gmail.com>
[not found] ` <835zg5m7ib.fsf@gnu.org>
2020-02-22 11:33 ` Eli Zaretskii
2020-02-22 15:55 ` Simon Marchi [this message]
2020-02-22 16:04 ` Eli Zaretskii
2020-02-22 16:37 ` Eli Zaretskii
2020-02-22 18:06 ` Tom Tromey
2020-02-22 18:05 ` Tom Tromey
2020-02-22 18:23 ` Eli Zaretskii
2020-02-22 18:46 ` Eli Zaretskii
2020-02-22 19:10 ` Tom Tromey
2020-02-22 20:19 ` Eli Zaretskii
2020-02-22 19:02 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f41a400-0c17-4fec-3de1-0bd93423298f@simark.ca \
--to=simark@simark.ca \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=gdb@sourceware.org \
--cc=midenok@gmail.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox