From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95599 invoked by alias); 22 Feb 2020 15:55:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95581 invoked by uid 89); 22 Feb 2020 15:55:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:83mu9aj, H*MI:sk:83mu9aj, H*i:sk:83mu9aj, HX-Languages-Length:1421 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 22 Feb 2020 15:55:25 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D17B31E530; Sat, 22 Feb 2020 10:55:20 -0500 (EST) Subject: Re: GDB 9 TUI mode broken To: Eli Zaretskii , Tom Tromey Cc: midenok@gmail.com, gdb@sourceware.org, gdb-patches@sourceware.org References: <835zg5m7ib.fsf@gnu.org> <83mu9aj1pj.fsf@gnu.org> From: Simon Marchi Message-ID: <8f41a400-0c17-4fec-3de1-0bd93423298f@simark.ca> Date: Sat, 22 Feb 2020 15:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <83mu9aj1pj.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00882.txt.bz2 On 2020-02-22 6:33 a.m., Eli Zaretskii wrote: >> Date: Mon, 17 Feb 2020 19:46:36 +0200 >> From: Eli Zaretskii >> CC: gdb@sourceware.org >> >>> From: Aleksey Midenkov >>> Date: Mon, 17 Feb 2020 19:26:07 +0300 >>> >>> Now the window molders away after `winheight src +8` command. >> >> This looks like a bug, and is probably unrelated to colors. Suggest >> to make a bug report. > > The patch below seems to fix some of the problem, but not all of it: > the position of the status line (the one that shows the process > information) is not updated correctly. > > Tom, where's the position update of the status line supposed to be > handled? > > And btw, the meaning of the 'locator' object in tui_adjust_win_heights > is unclear: to which window does it pertain, and what is the > significance of this line: > > TUI_CMD_WIN->origin.y = locator->origin.y + 1; > > I think we could use some additional comments in tui-stack.c or > tui-stack.h, to explain what is the meaning and expected use of > tui_locator_window. The locator window is the line that sits between the source windows and the command line's window (in the TUI's source layout). It displays information such as current thread id, current line and current PC. I learned this watching Tom's excellent FOSDEM presentation, here :) https://fosdem.org/2020/schedule/event/debugging_gdb_tui/ Simon