Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simark@simark.ca>
Cc: tom@tromey.com, midenok@gmail.com, gdb-patches@sourceware.org
Subject: Re: GDB 9 TUI mode broken
Date: Sat, 22 Feb 2020 16:04:00 -0000	[thread overview]
Message-ID: <83imjyip6n.fsf@gnu.org> (raw)
In-Reply-To: <8f41a400-0c17-4fec-3de1-0bd93423298f@simark.ca> (message from	Simon Marchi on Sat, 22 Feb 2020 10:55:19 -0500)

> Cc: midenok@gmail.com, gdb@sourceware.org, gdb-patches@sourceware.org
> From: Simon Marchi <simark@simark.ca>
> Date: Sat, 22 Feb 2020 10:55:19 -0500
> 
> > And btw, the meaning of the 'locator' object in tui_adjust_win_heights
> > is unclear: to which window does it pertain, and what is the
> > significance of this line:
> > 
> > 	      TUI_CMD_WIN->origin.y = locator->origin.y + 1;
> > 
> > I think we could use some additional comments in tui-stack.c or
> > tui-stack.h, to explain what is the meaning and expected use of
> > tui_locator_window.
> 
> The locator window is the line that sits between the source windows and the command
> line's window (in the TUI's source layout).  It displays information such as current
> thread id, current line and current PC.

Thanks; I wish this was spelled out in our comments.

The next question is: what code readjusts the location of the locator
window when the source or the command window is resized, and where is
that code called?  because the preceding code in
tui_adjust_win_heights modifies only 2 windows: the one whose height
was directly changed by the winheight command, and the other one,
which is displayed above or below it.


  reply	other threads:[~2020-02-22 16:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAF8BazBni=TZWTc5fbpdHU5bv1eM=24xpML46GCC2u4pFTkSAw@mail.gmail.com>
     [not found] ` <835zg5m7ib.fsf@gnu.org>
2020-02-22 11:33   ` Eli Zaretskii
2020-02-22 15:55     ` Simon Marchi
2020-02-22 16:04       ` Eli Zaretskii [this message]
2020-02-22 16:37         ` Eli Zaretskii
2020-02-22 18:06         ` Tom Tromey
2020-02-22 18:05     ` Tom Tromey
2020-02-22 18:23       ` Eli Zaretskii
2020-02-22 18:46         ` Eli Zaretskii
2020-02-22 19:10           ` Tom Tromey
2020-02-22 20:19             ` Eli Zaretskii
2020-02-22 19:02         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83imjyip6n.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=midenok@gmail.com \
    --cc=simark@simark.ca \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox