From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104453 invoked by alias); 22 Feb 2020 16:04:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104444 invoked by uid 89); 22 Feb 2020 16:04:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_BL_SPAMCOP_NET,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.1 spammy=H*MI:sk:8f41a40, H*f:sk:8f41a40, spelled, our X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 22 Feb 2020 16:04:26 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j5XGS-0007zY-MI; Sat, 22 Feb 2020 11:04:24 -0500 Received: from [176.228.60.248] (port=4916 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j5XGR-0001Uh-Mi; Sat, 22 Feb 2020 11:04:24 -0500 Date: Sat, 22 Feb 2020 16:04:00 -0000 Message-Id: <83imjyip6n.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: tom@tromey.com, midenok@gmail.com, gdb-patches@sourceware.org In-reply-to: <8f41a400-0c17-4fec-3de1-0bd93423298f@simark.ca> (message from Simon Marchi on Sat, 22 Feb 2020 10:55:19 -0500) Subject: Re: GDB 9 TUI mode broken References: <835zg5m7ib.fsf@gnu.org> <83mu9aj1pj.fsf@gnu.org> <8f41a400-0c17-4fec-3de1-0bd93423298f@simark.ca> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00883.txt.bz2 > Cc: midenok@gmail.com, gdb@sourceware.org, gdb-patches@sourceware.org > From: Simon Marchi > Date: Sat, 22 Feb 2020 10:55:19 -0500 > > > And btw, the meaning of the 'locator' object in tui_adjust_win_heights > > is unclear: to which window does it pertain, and what is the > > significance of this line: > > > > TUI_CMD_WIN->origin.y = locator->origin.y + 1; > > > > I think we could use some additional comments in tui-stack.c or > > tui-stack.h, to explain what is the meaning and expected use of > > tui_locator_window. > > The locator window is the line that sits between the source windows and the command > line's window (in the TUI's source layout). It displays information such as current > thread id, current line and current PC. Thanks; I wish this was spelled out in our comments. The next question is: what code readjusts the location of the locator window when the source or the command window is resized, and where is that code called? because the preceding code in tui_adjust_win_heights modifies only 2 windows: the one whose height was directly changed by the winheight command, and the other one, which is displayed above or below it.