From: "Jim Blandy" <jimb@red-bean.com>
To: luisgpm@linux.vnet.ibm.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix DW_CFA_restore_extended parsing
Date: Fri, 21 Dec 2007 19:16:00 -0000 [thread overview]
Message-ID: <8f2776cb0712211103u53390fb0m935c2f16e7335ec3@mail.gmail.com> (raw)
In-Reply-To: <1198245586.9817.29.camel@gargoyle>
On Dec 21, 2007 5:59 AM, Luis Machado <luisgpm@linux.vnet.ibm.com> wrote:
> On Thu, 2007-12-20 at 14:03 -0800, Jim Blandy wrote:
> > The only difference between those two opcodes is in their encoding ---
> > the action to be performed is identical. It seems silly to duplicate
> > the code. Could you pull the common code out into its own function,
> > and then have both cases simply parse their arguments and call the
> > function?
>
> Like so?
Yes --- looks great. Please commit. Thanks!
next prev parent reply other threads:[~2007-12-21 19:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 20:25 Luis Machado
2007-12-21 0:49 ` Jim Blandy
2007-12-21 14:02 ` Luis Machado
2007-12-21 19:16 ` Jim Blandy [this message]
2007-12-26 11:22 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f2776cb0712211103u53390fb0m935c2f16e7335ec3@mail.gmail.com \
--to=jimb@red-bean.com \
--cc=gdb-patches@sourceware.org \
--cc=luisgpm@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox