From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4252 invoked by alias); 21 Dec 2007 19:03:24 -0000 Received: (qmail 4243 invoked by uid 22791); 21 Dec 2007 19:03:23 -0000 X-Spam-Check-By: sourceware.org Received: from py-out-1112.google.com (HELO py-out-1112.google.com) (64.233.166.178) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 21 Dec 2007 19:03:17 +0000 Received: by py-out-1112.google.com with SMTP id d32so2034147pye.12 for ; Fri, 21 Dec 2007 11:03:07 -0800 (PST) Received: by 10.35.128.1 with SMTP id f1mr1741792pyn.63.1198263787753; Fri, 21 Dec 2007 11:03:07 -0800 (PST) Received: by 10.35.36.15 with HTTP; Fri, 21 Dec 2007 11:03:07 -0800 (PST) Message-ID: <8f2776cb0712211103u53390fb0m935c2f16e7335ec3@mail.gmail.com> Date: Fri, 21 Dec 2007 19:16:00 -0000 From: "Jim Blandy" To: luisgpm@linux.vnet.ibm.com Subject: Re: [PATCH] Fix DW_CFA_restore_extended parsing Cc: gdb-patches@sourceware.org In-Reply-To: <1198245586.9817.29.camel@gargoyle> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1198182171.9817.22.camel@gargoyle> <8f2776cb0712201403j593ffc0bg846b1a654a09d8bb@mail.gmail.com> <1198245586.9817.29.camel@gargoyle> X-Google-Sender-Auth: 73d05f2e46f1f64c X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00385.txt.bz2 On Dec 21, 2007 5:59 AM, Luis Machado wrote: > On Thu, 2007-12-20 at 14:03 -0800, Jim Blandy wrote: > > The only difference between those two opcodes is in their encoding --- > > the action to be performed is identical. It seems silly to duplicate > > the code. Could you pull the common code out into its own function, > > and then have both cases simply parse their arguments and call the > > function? > > Like so? Yes --- looks great. Please commit. Thanks!