From: "Jim Blandy" <jimb@red-bean.com>
To: luisgpm@linux.vnet.ibm.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix DW_CFA_restore_extended parsing
Date: Fri, 21 Dec 2007 00:49:00 -0000 [thread overview]
Message-ID: <8f2776cb0712201403j593ffc0bg846b1a654a09d8bb@mail.gmail.com> (raw)
In-Reply-To: <1198182171.9817.22.camel@gargoyle>
On Dec 20, 2007 12:22 PM, Luis Machado <luisgpm@linux.vnet.ibm.com> wrote:
> This simple patch fixes the issue. Any thoughts? Ok to commit?
The only difference between those two opcodes is in their encoding ---
the action to be performed is identical. It seems silly to duplicate
the code. Could you pull the common code out into its own function,
and then have both cases simply parse their arguments and call the
function?
next prev parent reply other threads:[~2007-12-20 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 20:25 Luis Machado
2007-12-21 0:49 ` Jim Blandy [this message]
2007-12-21 14:02 ` Luis Machado
2007-12-21 19:16 ` Jim Blandy
2007-12-26 11:22 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f2776cb0712201403j593ffc0bg846b1a654a09d8bb@mail.gmail.com \
--to=jimb@red-bean.com \
--cc=gdb-patches@sourceware.org \
--cc=luisgpm@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox