From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28562 invoked by alias); 20 Dec 2007 22:03:59 -0000 Received: (qmail 28546 invoked by uid 22791); 20 Dec 2007 22:03:59 -0000 X-Spam-Check-By: sourceware.org Received: from rv-out-0910.google.com (HELO rv-out-0910.google.com) (209.85.198.187) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Dec 2007 22:03:55 +0000 Received: by rv-out-0910.google.com with SMTP id l15so37089rvb.48 for ; Thu, 20 Dec 2007 14:03:53 -0800 (PST) Received: by 10.140.54.6 with SMTP id c6mr343056rva.37.1198188233249; Thu, 20 Dec 2007 14:03:53 -0800 (PST) Received: by 10.35.36.15 with HTTP; Thu, 20 Dec 2007 14:03:53 -0800 (PST) Message-ID: <8f2776cb0712201403j593ffc0bg846b1a654a09d8bb@mail.gmail.com> Date: Fri, 21 Dec 2007 00:49:00 -0000 From: "Jim Blandy" To: luisgpm@linux.vnet.ibm.com Subject: Re: [PATCH] Fix DW_CFA_restore_extended parsing Cc: gdb-patches@sourceware.org In-Reply-To: <1198182171.9817.22.camel@gargoyle> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1198182171.9817.22.camel@gargoyle> X-Google-Sender-Auth: a327a4494b8fba36 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00356.txt.bz2 On Dec 20, 2007 12:22 PM, Luis Machado wrote: > This simple patch fixes the issue. Any thoughts? Ok to commit? The only difference between those two opcodes is in their encoding --- the action to be performed is identical. It seems silly to duplicate the code. Could you pull the common code out into its own function, and then have both cases simply parse their arguments and call the function?