From: "Jim Blandy" <jimb@red-bean.com>
To: "Michael Snyder" <msnyder@redhat.com>
Cc: gdb-patches@sourceware.org, "Daniel Jacobowitz" <drow@false.org>
Subject: Re: [RFA/RFC] dwarf2-frame read_reg
Date: Wed, 12 Apr 2006 04:42:00 -0000 [thread overview]
Message-ID: <8f2776cb0604112142i32dcdf0dic8f44f2989311786@mail.gmail.com> (raw)
In-Reply-To: <443C7529.7020206@redhat.com>
On 4/11/06, Michael Snyder <msnyder@redhat.com> wrote:
> I want you guys to vett this change. I was getting wrong results
> on a target where sizeof (SP) != sizeof (void *). The local func
> read_reg was calling extract_unsigned_integer with the wrong size.
Well, extract_typed_address requires the type of the register to be
some sort of pointer. read_reg is given as a callback to the Dwarf
expression evaluator in dwarf2expr.c, so it could be handed any
register at all.
How about unpack_long (buf, register_type (gdbarch, regnum))?
Definitely regression-test this on several platforms...
next prev parent reply other threads:[~2006-04-12 4:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-12 3:34 Michael Snyder
2006-04-12 4:42 ` Jim Blandy [this message]
2006-04-12 18:18 ` Mark Kettenis
2006-04-12 19:15 ` Michael Snyder
2006-04-20 17:21 ` Daniel Jacobowitz
2006-04-20 19:06 ` Michael Snyder
2006-04-20 19:10 ` Mark Kettenis
2006-04-12 19:20 ` Michael Snyder
2006-05-05 19:44 ` Daniel Jacobowitz
2006-05-17 15:01 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f2776cb0604112142i32dcdf0dic8f44f2989311786@mail.gmail.com \
--to=jimb@red-bean.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox