From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5937 invoked by alias); 12 Apr 2006 04:42:06 -0000 Received: (qmail 5897 invoked by uid 22791); 12 Apr 2006 04:42:05 -0000 X-Spam-Check-By: sourceware.org Received: from xproxy.gmail.com (HELO xproxy.gmail.com) (66.249.82.201) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 12 Apr 2006 04:42:04 +0000 Received: by xproxy.gmail.com with SMTP id s16so1009350wxc for ; Tue, 11 Apr 2006 21:42:02 -0700 (PDT) Received: by 10.70.27.2 with SMTP id a2mr936666wxa; Tue, 11 Apr 2006 21:42:01 -0700 (PDT) Received: by 10.70.125.5 with HTTP; Tue, 11 Apr 2006 21:42:01 -0700 (PDT) Message-ID: <8f2776cb0604112142i32dcdf0dic8f44f2989311786@mail.gmail.com> Date: Wed, 12 Apr 2006 04:42:00 -0000 From: "Jim Blandy" To: "Michael Snyder" Subject: Re: [RFA/RFC] dwarf2-frame read_reg Cc: gdb-patches@sourceware.org, "Daniel Jacobowitz" In-Reply-To: <443C7529.7020206@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <443C7529.7020206@redhat.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00143.txt.bz2 On 4/11/06, Michael Snyder wrote: > I want you guys to vett this change. I was getting wrong results > on a target where sizeof (SP) !=3D sizeof (void *). The local func > read_reg was calling extract_unsigned_integer with the wrong size. Well, extract_typed_address requires the type of the register to be some sort of pointer. read_reg is given as a callback to the Dwarf expression evaluator in dwarf2expr.c, so it could be handed any register at all. How about unpack_long (buf, register_type (gdbarch, regnum))?=20 Definitely regression-test this on several platforms...