Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: gdb-patches@sourceware.org
Cc: Jim Blandy <jimb@red-bean.com>, Daniel Jacobowitz <drow@false.org>
Subject: [RFA/RFC] dwarf2-frame read_reg
Date: Wed, 12 Apr 2006 03:34:00 -0000	[thread overview]
Message-ID: <443C7529.7020206@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

I want you guys to vett this change.  I was getting wrong results
on a target where sizeof (SP) != sizeof (void *).  The local func
read_reg was calling extract_unsigned_integer with the wrong size.




[-- Attachment #2: read_reg --]
[-- Type: text/plain, Size: 933 bytes --]

2006-04-11  Michael Snyder  <msnyder@redhat.com>

	* dwarf2-frame.c (read_reg): Use register type instead of 
	builtin_data_pointer_type to extract register's value.

Index: dwarf2-frame.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2-frame.c,v
retrieving revision 1.59
diff -p -r1.59 dwarf2-frame.c
*** dwarf2-frame.c	5 Apr 2006 20:01:19 -0000	1.59
--- dwarf2-frame.c	12 Apr 2006 03:30:08 -0000
*************** read_reg (void *baton, int reg)
*** 214,220 ****
  
    buf = alloca (register_size (gdbarch, regnum));
    frame_unwind_register (next_frame, regnum, buf);
!   return extract_typed_address (buf, builtin_type_void_data_ptr);
  }
  
  static void
--- 214,220 ----
  
    buf = alloca (register_size (gdbarch, regnum));
    frame_unwind_register (next_frame, regnum, buf);
!   return extract_typed_address (buf, register_type (gdbarch, regnum));
  }
  
  static void

             reply	other threads:[~2006-04-12  3:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-12  3:34 Michael Snyder [this message]
2006-04-12  4:42 ` Jim Blandy
2006-04-12 18:18   ` Mark Kettenis
2006-04-12 19:15     ` Michael Snyder
2006-04-20 17:21     ` Daniel Jacobowitz
2006-04-20 19:06       ` Michael Snyder
2006-04-20 19:10       ` Mark Kettenis
2006-04-12 19:20   ` Michael Snyder
2006-05-05 19:44 ` Daniel Jacobowitz
2006-05-17 15:01   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=443C7529.7020206@redhat.com \
    --to=msnyder@redhat.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jimb@red-bean.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox