From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6330 invoked by alias); 12 Apr 2006 03:34:10 -0000 Received: (qmail 6322 invoked by uid 22791); 12 Apr 2006 03:34:10 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 12 Apr 2006 03:34:08 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k3C3Y4s8006421; Tue, 11 Apr 2006 23:34:04 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id k3C3Y48m024413; Tue, 11 Apr 2006 23:34:04 -0400 Received: from [172.16.24.50] (bluegiant.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id k3C3Y2Tq005529; Tue, 11 Apr 2006 23:34:02 -0400 Message-ID: <443C7529.7020206@redhat.com> Date: Wed, 12 Apr 2006 03:34:00 -0000 From: Michael Snyder User-Agent: Mozilla Thunderbird 1.0.7-1.4.1 (X11/20050929) MIME-Version: 1.0 To: gdb-patches@sourceware.org CC: Jim Blandy , Daniel Jacobowitz Subject: [RFA/RFC] dwarf2-frame read_reg Content-Type: multipart/mixed; boundary="------------090909020608060200090901" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00142.txt.bz2 This is a multi-part message in MIME format. --------------090909020608060200090901 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 202 I want you guys to vett this change. I was getting wrong results on a target where sizeof (SP) != sizeof (void *). The local func read_reg was calling extract_unsigned_integer with the wrong size. --------------090909020608060200090901 Content-Type: text/plain; name="read_reg" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="read_reg" Content-length: 933 2006-04-11 Michael Snyder * dwarf2-frame.c (read_reg): Use register type instead of builtin_data_pointer_type to extract register's value. Index: dwarf2-frame.c =================================================================== RCS file: /cvs/src/src/gdb/dwarf2-frame.c,v retrieving revision 1.59 diff -p -r1.59 dwarf2-frame.c *** dwarf2-frame.c 5 Apr 2006 20:01:19 -0000 1.59 --- dwarf2-frame.c 12 Apr 2006 03:30:08 -0000 *************** read_reg (void *baton, int reg) *** 214,220 **** buf = alloca (register_size (gdbarch, regnum)); frame_unwind_register (next_frame, regnum, buf); ! return extract_typed_address (buf, builtin_type_void_data_ptr); } static void --- 214,220 ---- buf = alloca (register_size (gdbarch, regnum)); frame_unwind_register (next_frame, regnum, buf); ! return extract_typed_address (buf, register_type (gdbarch, regnum)); } static void --------------090909020608060200090901--