From: Jim Blandy <jimb@red-bean.com>
To: Jie Zhang <jzhang918@gmail.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Add support for Analog Devices Blackfin processor (part 1/6: gdb)
Date: Mon, 09 Jan 2006 05:35:00 -0000 [thread overview]
Message-ID: <8f2776cb0601082135t6cc5d57ep9197a5a05ff2431e@mail.gmail.com> (raw)
In-Reply-To: <43C1E7CD.7010001@gmail.com>
On 1/8/06, Jie Zhang <jzhang918@gmail.com> wrote:
> Again here is a new patch with source code clean up as you pointed out.
Thanks. It looks good.
There is something that I noticed before but forgot to ask about (sorry):
+/* The list of available "set bfin ..." and "show bfin ..." commands. */
+
+static struct cmd_list_element *setbfincmdlist = NULL;
+static struct cmd_list_element *showbfincmdlist = NULL;
+
These seem to be unused. If there is missing code to be added, then
that needs to be posted for review. But if they can simply be
deleted, I think the GDB port is okay to commit as soon as the
paperwork is ready (I'm just waiting for the Analog Devices assignment
for GDB to appear in copyright.list, along with the ones for GCC,
libstdc++, and binutils).
next prev parent reply other threads:[~2006-01-09 5:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-29 13:41 Jie Zhang
2006-01-04 5:28 ` Jim Blandy
2006-01-05 16:48 ` Jie Zhang
2006-01-05 18:51 ` Jim Blandy
2006-01-09 4:34 ` Jie Zhang
2006-01-09 5:35 ` Jim Blandy [this message]
2006-01-05 18:55 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f2776cb0601082135t6cc5d57ep9197a5a05ff2431e@mail.gmail.com \
--to=jimb@red-bean.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jzhang918@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox