From: Jim Blandy <jimb@red-bean.com>
To: Jie Zhang <jzhang918@gmail.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Add support for Analog Devices Blackfin processor (part 1/6: gdb)
Date: Wed, 04 Jan 2006 05:28:00 -0000 [thread overview]
Message-ID: <8f2776cb0601032128o3f4ef886lfde9e1fcca2e3202@mail.gmail.com> (raw)
In-Reply-To: <43B15F54.5040903@gmail.com>
Why do you need the changes to configure.host, and the bfin.mh file?
You can't run GDB itself on the blackfin processor, can you? It
doesn't have an MMU, and I've never heard of GDB running on uClinux.
In bfin_linux_pc_in_sigtramp, you should pass in the frame and use
safe_frame_unwind_memory instead of deprecated_read_memory_nobpt. It
looks to me like you always have a frame handy --- is that right?
+ frame_unwind_register (next_frame, BFIN_SP_REGNUM, buf);
+ sp = extract_unsigned_integer (buf, 4);
Is it possible to simply use frame_unwind_register_unsigned in places like this?
Am I reading bfin_frame_prev_register correctly when I conclude that
the only saved registers it can find are the PC and the FP? How are
the test suite results?
+#include "bfd-in2.h"
+
Why is this needed? Shouldn't the #include "bfd.h" in defs.h be sufficient?
Other than that, it looks nice.
next prev parent reply other threads:[~2006-01-04 5:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-29 13:41 Jie Zhang
2006-01-04 5:28 ` Jim Blandy [this message]
2006-01-05 16:48 ` Jie Zhang
2006-01-05 18:51 ` Jim Blandy
2006-01-09 4:34 ` Jie Zhang
2006-01-09 5:35 ` Jim Blandy
2006-01-05 18:55 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f2776cb0601032128o3f4ef886lfde9e1fcca2e3202@mail.gmail.com \
--to=jimb@red-bean.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jzhang918@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox