From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1970 invoked by alias); 4 Jan 2006 05:28:35 -0000 Received: (qmail 1963 invoked by uid 22791); 4 Jan 2006 05:28:35 -0000 X-Spam-Check-By: sourceware.org Received: from zproxy.gmail.com (HELO zproxy.gmail.com) (64.233.162.204) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 04 Jan 2006 05:28:32 +0000 Received: by zproxy.gmail.com with SMTP id l1so2881198nzf for ; Tue, 03 Jan 2006 21:28:30 -0800 (PST) Received: by 10.37.20.49 with SMTP id x49mr4826800nzi; Tue, 03 Jan 2006 21:28:30 -0800 (PST) Received: by 10.37.2.42 with HTTP; Tue, 3 Jan 2006 21:28:30 -0800 (PST) Message-ID: <8f2776cb0601032128o3f4ef886lfde9e1fcca2e3202@mail.gmail.com> Date: Wed, 04 Jan 2006 05:28:00 -0000 From: Jim Blandy To: Jie Zhang Subject: Re: [PATCH] Add support for Analog Devices Blackfin processor (part 1/6: gdb) Cc: gdb-patches@sources.redhat.com In-Reply-To: <43B15F54.5040903@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <43B15F54.5040903@gmail.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00025.txt.bz2 Why do you need the changes to configure.host, and the bfin.mh file?=20 You can't run GDB itself on the blackfin processor, can you? It doesn't have an MMU, and I've never heard of GDB running on uClinux. In bfin_linux_pc_in_sigtramp, you should pass in the frame and use safe_frame_unwind_memory instead of deprecated_read_memory_nobpt. It looks to me like you always have a frame handy --- is that right? + frame_unwind_register (next_frame, BFIN_SP_REGNUM, buf); + sp =3D extract_unsigned_integer (buf, 4); Is it possible to simply use frame_unwind_register_unsigned in places like = this? Am I reading bfin_frame_prev_register correctly when I conclude that the only saved registers it can find are the PC and the FP? How are the test suite results? +#include "bfd-in2.h" + Why is this needed? Shouldn't the #include "bfd.h" in defs.h be sufficient? Other than that, it looks nice.