From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22200 invoked by alias); 9 Jan 2006 05:35:53 -0000 Received: (qmail 21639 invoked by uid 22791); 9 Jan 2006 05:35:52 -0000 X-Spam-Check-By: sourceware.org Received: from zproxy.gmail.com (HELO zproxy.gmail.com) (64.233.162.200) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 09 Jan 2006 05:35:51 +0000 Received: by zproxy.gmail.com with SMTP id 34so3741332nzf for ; Sun, 08 Jan 2006 21:35:49 -0800 (PST) Received: by 10.36.222.40 with SMTP id u40mr130787nzg; Sun, 08 Jan 2006 21:35:49 -0800 (PST) Received: by 10.37.2.42 with HTTP; Sun, 8 Jan 2006 21:35:49 -0800 (PST) Message-ID: <8f2776cb0601082135t6cc5d57ep9197a5a05ff2431e@mail.gmail.com> Date: Mon, 09 Jan 2006 05:35:00 -0000 From: Jim Blandy To: Jie Zhang Subject: Re: [PATCH] Add support for Analog Devices Blackfin processor (part 1/6: gdb) Cc: gdb-patches@sources.redhat.com In-Reply-To: <43C1E7CD.7010001@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <43B15F54.5040903@gmail.com> <8f2776cb0601032128o3f4ef886lfde9e1fcca2e3202@mail.gmail.com> <43BD4C00.70608@gmail.com> <8f2776cb0601051050o7b1bbe09xa346220e0b526cbe@mail.gmail.com> <43C1E7CD.7010001@gmail.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00093.txt.bz2 On 1/8/06, Jie Zhang wrote: > Again here is a new patch with source code clean up as you pointed out. Thanks. It looks good. There is something that I noticed before but forgot to ask about (sorry): +/* The list of available "set bfin ..." and "show bfin ..." commands. */ + +static struct cmd_list_element *setbfincmdlist =3D NULL; +static struct cmd_list_element *showbfincmdlist =3D NULL; + These seem to be unused. If there is missing code to be added, then that needs to be posted for review. But if they can simply be deleted, I think the GDB port is okay to commit as soon as the paperwork is ready (I'm just waiting for the Analog Devices assignment for GDB to appear in copyright.list, along with the ones for GCC, libstdc++, and binutils).