Re: [PING] 13 months and counting for PR symtab/1651 fix.

Re: [PING] 13 months and counting for PR symtab/1651 fix.

[Jim Blandy]

On 12/30/05, Roger Sayle <roger@eyesopen.com> wrote:
> Being the season of good-will, is there any chance some kind soul
> could commit this fix to CVS, and thereby close "serious" bug
> symtab/1651 in gdb's bug database?

I've committed Elena's patch, and closed the bug.  Happy New Year!

Re: [PING] 13 months and counting for PR symtab/1651 fix.

[Jim Blandy]

On 1/1/06, Jim Blandy <jimb@red-bean.com> wrote:
> On 12/30/05, Roger Sayle <roger@eyesopen.com> wrote:
> > Being the season of good-will, is there any chance some kind soul
> > could commit this fix to CVS, and thereby close "serious" bug
> > symtab/1651 in gdb's bug database?
>
> I've committed Elena's patch, and closed the bug.  Happy New Year!

Here's what I actually committed:


gdb/ChangeLog:
2006-01-01  Roger Sayle  <roger@eyesopen.com>
            Elena Zannoni <ezannoni@redhat.com>

	PR symtab/1651
	* xcoffread.c (xcoff_next_symbol_text): Check this_symtab_psymtab
	for NULL before assigning this_symtab_psymtab->objfile to objfile.
	(scan_xcoff_symtab): Initialize next_symbol_text_func.
        (Committed by Jim Blandy)

Index: gdb/xcoffread.c
===================================================================
RCS file: /cvs/src/src/gdb/xcoffread.c,v
retrieving revision 1.47
diff -c -p -r1.47 xcoffread.c
*** gdb/xcoffread.c	17 Dec 2005 22:34:03 -0000	1.47
--- gdb/xcoffread.c	2 Jan 2006 04:30:25 -0000
*************** xcoff_next_symbol_text (struct objfile *
*** 868,874 ****
    struct internal_syment symbol;
    char *retval;
    /* FIXME: is this the same as the passed arg? */
!   objfile = this_symtab_psymtab->objfile;

    bfd_coff_swap_sym_in (objfile->obfd, raw_symbol, &symbol);
    if (symbol.n_zeroes)
--- 868,875 ----
    struct internal_syment symbol;
    char *retval;
    /* FIXME: is this the same as the passed arg? */
!   if (this_symtab_psymtab)
!     objfile = this_symtab_psymtab->objfile;

    bfd_coff_swap_sym_in (objfile->obfd, raw_symbol, &symbol);
    if (symbol.n_zeroes)
*************** scan_xcoff_symtab (struct objfile *objfi
*** 2170,2175 ****
--- 2171,2177 ----
    last_source_file = NULL;

    abfd = objfile->obfd;
+   next_symbol_text_func = xcoff_next_symbol_text;

    sraw_symbol = ((struct coff_symfile_info *)
objfile->deprecated_sym_private)->symtbl;
    nsyms = ((struct coff_symfile_info *)
objfile->deprecated_sym_private)->symtbl_num_syms;