From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13197 invoked by alias); 2 Jan 2006 05:52:02 -0000 Received: (qmail 12887 invoked by uid 22791); 2 Jan 2006 05:52:01 -0000 X-Spam-Check-By: sourceware.org Received: from zproxy.gmail.com (HELO zproxy.gmail.com) (64.233.162.198) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 02 Jan 2006 05:52:00 +0000 Received: by zproxy.gmail.com with SMTP id l1so2431702nzf for ; Sun, 01 Jan 2006 21:51:58 -0800 (PST) Received: by 10.36.227.5 with SMTP id z5mr1594023nzg; Sun, 01 Jan 2006 21:51:58 -0800 (PST) Received: by 10.37.2.42 with HTTP; Sun, 1 Jan 2006 21:51:58 -0800 (PST) Message-ID: <8f2776cb0601012151y30cf2672i8b32f958f605a982@mail.gmail.com> Date: Mon, 02 Jan 2006 05:52:00 -0000 From: Jim Blandy To: Roger Sayle Subject: Re: [PING] 13 months and counting for PR symtab/1651 fix. Cc: gdb-patches@sources.redhat.com In-Reply-To: <8f2776cb0601012033h738f5983g9dc7450caffa8a88@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <8f2776cb0601012033h738f5983g9dc7450caffa8a88@mail.gmail.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00005.txt.bz2 On 1/1/06, Jim Blandy wrote: > On 12/30/05, Roger Sayle wrote: > > Being the season of good-will, is there any chance some kind soul > > could commit this fix to CVS, and thereby close "serious" bug > > symtab/1651 in gdb's bug database? > > I've committed Elena's patch, and closed the bug. Happy New Year! Here's what I actually committed: gdb/ChangeLog: 2006-01-01 Roger Sayle Elena Zannoni PR symtab/1651 * xcoffread.c (xcoff_next_symbol_text): Check this_symtab_psymtab for NULL before assigning this_symtab_psymtab->objfile to objfile. (scan_xcoff_symtab): Initialize next_symbol_text_func. (Committed by Jim Blandy) Index: gdb/xcoffread.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/xcoffread.c,v retrieving revision 1.47 diff -c -p -r1.47 xcoffread.c *** gdb/xcoffread.c 17 Dec 2005 22:34:03 -0000 1.47 --- gdb/xcoffread.c 2 Jan 2006 04:30:25 -0000 *************** xcoff_next_symbol_text (struct objfile * *** 868,874 **** struct internal_syment symbol; char *retval; /* FIXME: is this the same as the passed arg? */ ! objfile =3D this_symtab_psymtab->objfile; bfd_coff_swap_sym_in (objfile->obfd, raw_symbol, &symbol); if (symbol.n_zeroes) --- 868,875 ---- struct internal_syment symbol; char *retval; /* FIXME: is this the same as the passed arg? */ ! if (this_symtab_psymtab) ! objfile =3D this_symtab_psymtab->objfile; bfd_coff_swap_sym_in (objfile->obfd, raw_symbol, &symbol); if (symbol.n_zeroes) *************** scan_xcoff_symtab (struct objfile *objfi *** 2170,2175 **** --- 2171,2177 ---- last_source_file =3D NULL; abfd =3D objfile->obfd; + next_symbol_text_func =3D xcoff_next_symbol_text; sraw_symbol =3D ((struct coff_symfile_info *) objfile->deprecated_sym_private)->symtbl; nsyms =3D ((struct coff_symfile_info *) objfile->deprecated_sym_private)->symtbl_num_syms;