From: Jim Blandy <jimb@red-bean.com>
To: Andrew STUBBS <andrew.stubbs@st.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Allow spaces in filenames to load command
Date: Tue, 06 Dec 2005 18:23:00 -0000 [thread overview]
Message-ID: <8f2776cb0512051250u2a6083dbma95e6b352410dea8@mail.gmail.com> (raw)
In-Reply-To: <43949300.1040203@st.com>
On 12/5/05, Andrew STUBBS <andrew.stubbs@st.com> wrote:
> 2005-12-05 Andrew Stubbs <andrew.stubbs@st.com>
>
> * symfile.c (generic_load): Use buildargv and tilde_expand
> to parse file names with quoting, spaces and tildes properly.
Hi, Andrew. I like the idea of using buildargv and tilde_expand.
> + /* Do we have args from the user or from the default? */
> + if (exec_bfd && args == get_exec_file (1))
> + /* The string is ONLY the file name. */
> + filename = args;
What is this about? This seems very fragile.
next prev parent reply other threads:[~2005-12-05 20:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-06 17:06 Andrew STUBBS
2005-12-06 18:23 ` Jim Blandy [this message]
2005-12-06 20:28 ` Andrew STUBBS
2005-12-07 17:44 ` Jim Blandy
2005-12-07 19:35 ` Jim Blandy
2005-12-07 23:25 ` Andrew STUBBS
2005-12-08 0:19 ` Andrew STUBBS
2006-02-20 17:07 ` Daniel Jacobowitz
2006-02-20 20:03 ` Jim Blandy
2006-02-20 20:38 ` Daniel Jacobowitz
2006-02-21 18:27 ` Andrew STUBBS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f2776cb0512051250u2a6083dbma95e6b352410dea8@mail.gmail.com \
--to=jimb@red-bean.com \
--cc=andrew.stubbs@st.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox