From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21292 invoked by alias); 5 Dec 2005 20:50:53 -0000 Received: (qmail 21276 invoked by uid 22791); 5 Dec 2005 20:50:53 -0000 X-Spam-Check-By: sourceware.org Received: from zproxy.gmail.com (HELO zproxy.gmail.com) (64.233.162.206) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 05 Dec 2005 20:50:50 +0000 Received: by zproxy.gmail.com with SMTP id x3so856499nzd for ; Mon, 05 Dec 2005 12:50:48 -0800 (PST) Received: by 10.36.66.12 with SMTP id o12mr3811316nza; Mon, 05 Dec 2005 12:50:47 -0800 (PST) Received: by 10.37.2.6 with HTTP; Mon, 5 Dec 2005 12:50:47 -0800 (PST) Message-ID: <8f2776cb0512051250u2a6083dbma95e6b352410dea8@mail.gmail.com> Date: Tue, 06 Dec 2005 18:23:00 -0000 From: Jim Blandy To: Andrew STUBBS Subject: Re: [PATCH] Allow spaces in filenames to load command Cc: GDB Patches In-Reply-To: <43949300.1040203@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <43949300.1040203@st.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-12/txt/msg00108.txt.bz2 On 12/5/05, Andrew STUBBS wrote: > 2005-12-05 Andrew Stubbs > > * symfile.c (generic_load): Use buildargv and tilde_expand > to parse file names with quoting, spaces and tildes properly. Hi, Andrew. I like the idea of using buildargv and tilde_expand. > + /* Do we have args from the user or from the default? */ > + if (exec_bfd && args =3D=3D get_exec_file (1)) > + /* The string is ONLY the file name. */ > + filename =3D args; What is this about? This seems very fragile.