From: Daniel Jacobowitz <drow@false.org>
To: Andrew STUBBS <andrew.stubbs@st.com>
Cc: Jim Blandy <jimb@red-bean.com>,
GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Allow spaces in filenames to load command
Date: Mon, 20 Feb 2006 17:07:00 -0000 [thread overview]
Message-ID: <20060220170702.GH16058@nevyn.them.org> (raw)
In-Reply-To: <43972145.6020903@st.com>
On Wed, Dec 07, 2005 at 05:52:05PM +0000, Andrew STUBBS wrote:
> 2005-12-07 Andrew Stubbs <andrew.stubbs@st.com>
>
> * symfile.c (generic_load): Use buildargv() and tilde_expand()
> to parse file names with quoting, spaces and tildes properly.
> (load_command): Quote all special characters before calling
> target_load() such that buildargv() doesn't break file names.
> (_initialize_symfile): Mention the load offset in the help for
> the load command.
> * remote-sim.c: Include readline.h.
> (gdbsim_load): Use buildargv and tilde_expand() to parse file
> names with quoting, spaces and tildes properly.
> * target.h (target_load): Comment the parameters better.
> * Makefile.in (remote_sim.o): Add readline.h dependency.
This all looks plausible to me. Jim, do you want to take a look at
this, since you were previously?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-02-20 17:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-06 17:06 Andrew STUBBS
2005-12-06 18:23 ` Jim Blandy
2005-12-06 20:28 ` Andrew STUBBS
2005-12-07 17:44 ` Jim Blandy
2005-12-07 19:35 ` Jim Blandy
2005-12-07 23:25 ` Andrew STUBBS
2005-12-08 0:19 ` Andrew STUBBS
2006-02-20 17:07 ` Daniel Jacobowitz [this message]
2006-02-20 20:03 ` Jim Blandy
2006-02-20 20:38 ` Daniel Jacobowitz
2006-02-21 18:27 ` Andrew STUBBS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060220170702.GH16058@nevyn.them.org \
--to=drow@false.org \
--cc=andrew.stubbs@st.com \
--cc=gdb-patches@sourceware.org \
--cc=jimb@red-bean.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox