Re: [PATCH] Allow spaces in filenames to load command

Jim Blandy
2006-02-20T19:59:48Z

On 2/20/06, Daniel Jacobowitz <drow@false.org> wrote:
> On Wed, Dec 07, 2005 at 05:52:05PM +0000, Andrew STUBBS wrote:
> > 2005-12-07 Andrew Stubbs <andrew.stubbs@st.com>
> >
> > * symfile.c (generic_load): Use buildargv() and tilde_expand()
> > to parse file names with quoting, spaces and tildes properly.
> > (load_command): Quote all special characters before calling
> > target_load() such that buildargv() doesn't break file names.
> > (_initialize_symfile): Mention the load offset in the help for
> > the load command.
> > * remote-sim.c: Include readline.h.
> > (gdbsim_load): Use buildargv and tilde_expand() to parse file
> > names with quoting, spaces and tildes properly.
> > * target.h (target_load): Comment the parameters better.
> > * Makefile.in (remote_sim.o): Add readline.h dependency.
>
> This all looks plausible to me. Jim, do you want to take a look at
> this, since you were previously?

Yes --- this look good.

Ideally, the code added to load_command to do the quoting should be in
libiberty/argv.c. But this patch is fine as is.