Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@red-bean.com>
To: Frederic RISS <frederic.riss@st.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] DW_CFA_restore handling causes memory fault
Date: Fri, 18 Nov 2005 12:32:00 -0000	[thread overview]
Message-ID: <8f2776cb0511180035ndadf290ta81520f75cf601d5@mail.gmail.com> (raw)
In-Reply-To: <1132301881.8685.63.camel@crx549.cro.st.com>

On 11/18/05, Frederic RISS <frederic.riss@st.com> wrote:
> > Right; we're supposed to be prepared for mis-formed input.  It would
> > be nice to have a brief comment explaining that the 'else' half of the
> > 'if' does constitute questionable behavior on the part of the
> > compiler.
>
> Like in the attached patch ?

Yes!  But --- I apologize for not noticing this from the beginning ---
as I see your comment, it occurs to me that probably a call to
'complaint' would be better than just a comment.  Mark or Daniel can
string me up if they feel this will yield another 'incomplete CFI
data; unspecified blah blah blah' annoyance, but I think it's probably
the right thing.

With this change, I think it's okay to commit, so let's get the
paperwork out of the way.  If you're doing this as part of your paying
job, then the assignment from STMicroelectronics already on file
covers your work, so you just need to get an account on
sourceware.org, add yourself to the "write after approval" list in
gdb/MAINTAINERS, and then you can commit the change.

For the sourceware account, see
http://sourceware.org/cgi-bin/pdw/ps_form.cgi.  List me as the person
approving the request.


  reply	other threads:[~2005-11-18  8:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-17 18:58 Frederic RISS
2005-11-17 19:46 ` Jim Blandy
2005-11-18 12:12   ` Frederic RISS
2005-11-18 12:32     ` Jim Blandy [this message]
2005-11-18 13:30       ` Frederic RISS
2005-11-18 14:21         ` Mark Kettenis
2005-11-18 15:55           ` Frederic RISS
2005-11-23 16:51           ` Frederic RISS
2005-11-25 10:32             ` Mark Kettenis
2005-11-25 14:31               ` Frederic RISS
2005-11-25 18:35                 ` Daniel Jacobowitz
2005-11-25 23:00                 ` Mark Kettenis
2005-11-25 23:21                   ` Joel Brobecker
2005-11-28 19:30                     ` Frederic RISS
2005-11-18 14:43         ` Eli Zaretskii
2005-11-18 15:08           ` Frederic RISS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f2776cb0511180035ndadf290ta81520f75cf601d5@mail.gmail.com \
    --to=jimb@red-bean.com \
    --cc=frederic.riss@st.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox