Re: [RFC] DW_CFA_restore handling causes memory fault

[Mark Kettenis <mark.kettenis@xs4all.nl>]

> From: Frederic RISS <frederic.riss@st.com>
> Date: Wed, 23 Nov 2005 10:35:31 +0100
> 
> On Fri, 2005-11-18 at 14:45 +0100, Mark Kettenis wrote:
> > Formatted in what way?  Starting in column 0?  Well, that's because
> > it's easier to see whether the string will be longer than 80
> > characters, which your string will be once the %s is filled in. 
> 
> I just noticed that other complaints of the file will wrap because
> symfile complaints are prefixed with 'During symbol reading, '. I put
> the line break in my patch so that the first line is no longer that 80
> chars with the prefix.
> 
> >  So
> > could you split the string over two lines?  You're going to have to do
> > that anyway, because I'm going to ask you to make a little change: can
> > you also print the register number for the register that the complaint
> > is about?
> 
> Here's the latest version of the patch with the regnum printed out. Is
> it ok to commit ?

Sorry to be such a prick, but could you change the message in

          complaint (&symfile_complaints, _("\
incomplete CFI data; DW_CFA_restore unspecified\n\
register %s (#%d) at 0x%s"),
                     REGISTER_NAME(DWARF2_REG_TO_REGNUM(reg)),
                     DWARF2_REG_TO_REGNUM(reg), paddr (fs->pc));

I think that's less confusing.  With that change you've got my ok.
You're not listed in MAINTAINERS though.  Do you've got a copyright
assignment in place?

Mark