From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22056 invoked by alias); 24 Nov 2005 22:48:53 -0000 Received: (qmail 22049 invoked by uid 22791); 24 Nov 2005 22:48:53 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 24 Nov 2005 22:48:52 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id jAOMmDs8014659; Thu, 24 Nov 2005 23:48:13 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id jAOMmDi6008649; Thu, 24 Nov 2005 23:48:13 +0100 (CET) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id jAOMmCfC031451; Thu, 24 Nov 2005 23:48:12 +0100 (CET) Date: Fri, 25 Nov 2005 10:32:00 -0000 Message-Id: <200511242248.jAOMmCfC031451@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: frederic.riss@st.com CC: jimb@red-bean.com, gdb-patches@sources.redhat.com In-reply-to: <1132738531.7340.42.camel@crx549.cro.st.com> (message from Frederic RISS on Wed, 23 Nov 2005 10:35:31 +0100) Subject: Re: [RFC] DW_CFA_restore handling causes memory fault References: <1132242850.8685.47.camel@crx549.cro.st.com> <8f2776cb0511171132x17fa4192u6ca5af71201e0be3@mail.gmail.com> <1132301881.8685.63.camel@crx549.cro.st.com> <8f2776cb0511180035ndadf290ta81520f75cf601d5@mail.gmail.com> <1132317183.8685.101.camel@crx549.cro.st.com> <200511181345.jAIDjZNc026609@elgar.sibelius.xs4all.nl> <1132738531.7340.42.camel@crx549.cro.st.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-11/txt/msg00449.txt.bz2 > From: Frederic RISS > Date: Wed, 23 Nov 2005 10:35:31 +0100 > > On Fri, 2005-11-18 at 14:45 +0100, Mark Kettenis wrote: > > Formatted in what way? Starting in column 0? Well, that's because > > it's easier to see whether the string will be longer than 80 > > characters, which your string will be once the %s is filled in. > > I just noticed that other complaints of the file will wrap because > symfile complaints are prefixed with 'During symbol reading, '. I put > the line break in my patch so that the first line is no longer that 80 > chars with the prefix. > > > So > > could you split the string over two lines? You're going to have to do > > that anyway, because I'm going to ask you to make a little change: can > > you also print the register number for the register that the complaint > > is about? > > Here's the latest version of the patch with the regnum printed out. Is > it ok to commit ? Sorry to be such a prick, but could you change the message in complaint (&symfile_complaints, _("\ incomplete CFI data; DW_CFA_restore unspecified\n\ register %s (#%d) at 0x%s"), REGISTER_NAME(DWARF2_REG_TO_REGNUM(reg)), DWARF2_REG_TO_REGNUM(reg), paddr (fs->pc)); I think that's less confusing. With that change you've got my ok. You're not listed in MAINTAINERS though. Do you've got a copyright assignment in place? Mark