From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20944 invoked by alias); 18 Nov 2005 08:35:25 -0000 Received: (qmail 20911 invoked by uid 22791); 18 Nov 2005 08:35:23 -0000 Received: from zproxy.gmail.com (HELO zproxy.gmail.com) (64.233.162.199) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 18 Nov 2005 08:35:23 +0000 Received: by zproxy.gmail.com with SMTP id l1so143966nzf for ; Fri, 18 Nov 2005 00:35:21 -0800 (PST) Received: by 10.36.216.6 with SMTP id o6mr5620352nzg; Fri, 18 Nov 2005 00:35:21 -0800 (PST) Received: by 10.37.2.35 with HTTP; Fri, 18 Nov 2005 00:35:21 -0800 (PST) Message-ID: <8f2776cb0511180035ndadf290ta81520f75cf601d5@mail.gmail.com> Date: Fri, 18 Nov 2005 12:32:00 -0000 From: Jim Blandy To: Frederic RISS Subject: Re: [RFC] DW_CFA_restore handling causes memory fault Cc: gdb-patches@sources.redhat.com In-Reply-To: <1132301881.8685.63.camel@crx549.cro.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <1132242850.8685.47.camel@crx549.cro.st.com> <8f2776cb0511171132x17fa4192u6ca5af71201e0be3@mail.gmail.com> <1132301881.8685.63.camel@crx549.cro.st.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-11/txt/msg00314.txt.bz2 On 11/18/05, Frederic RISS wrote: > > Right; we're supposed to be prepared for mis-formed input. It would > > be nice to have a brief comment explaining that the 'else' half of the > > 'if' does constitute questionable behavior on the part of the > > compiler. > > Like in the attached patch ? Yes! But --- I apologize for not noticing this from the beginning --- as I see your comment, it occurs to me that probably a call to 'complaint' would be better than just a comment. Mark or Daniel can string me up if they feel this will yield another 'incomplete CFI data; unspecified blah blah blah' annoyance, but I think it's probably the right thing. With this change, I think it's okay to commit, so let's get the paperwork out of the way. If you're doing this as part of your paying job, then the assignment from STMicroelectronics already on file covers your work, so you just need to get an account on sourceware.org, add yourself to the "write after approval" list in gdb/MAINTAINERS, and then you can commit the change. For the sourceware account, see http://sourceware.org/cgi-bin/pdw/ps_form.cgi. List me as the person approving the request.