From: Pedro Alves <palves@redhat.com>
To: "Sturm, Michael" <michael.sturm@intel.com>,
mark.kettenis@xs4all.nl, eliz@gnu.org
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 5/5] Add support for Intel PKRU register to GDB and GDBserver.
Date: Fri, 27 Jan 2017 15:22:00 -0000 [thread overview]
Message-ID: <8efd1e4f-47f9-8fe6-6db9-b6824970d91d@redhat.com> (raw)
In-Reply-To: <588B607A.9040507@intel.com>
On 01/27/2017 03:00 PM, Sturm, Michael wrote:
>> In the test:
>>
>>> +#include <stdio.h>
>> This is not needed, right?
> It's needed to pull in the definition for NULL which is used in the call
> to __get_cpuid_
Ah. Could you include stddef.h instead? We avoid using stdio in tests
unless required for the specifics of the test, in order to be able to run
as most tests as possible against remote targets that don't support
remote I/O (which are most, though the local gdbserver testing boards nowadays
work around it). Just #including <stdio.h> without relying on printf etc. itself
is probably not really problematic anywhere, but it's a good proxy
for identifying tests that wouldn't/shouldn't work in such targets.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-01-27 15:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 10:58 [PATCH v3 0/5] Add support for PKRU register to GDB and GDBServer Michael Sturm
2016-12-06 10:58 ` [PATCH v3 3/5] Rename target descriptions to reflect actual content of description Michael Sturm
2017-01-26 14:50 ` Pedro Alves
2017-01-26 15:55 ` Sturm, Michael
2017-01-26 16:17 ` Pedro Alves
2016-12-06 10:58 ` [PATCH v3 1/5] Sync up x86-gcc-cpuid.h with cpuid.h from gcc-6 branch Michael Sturm
2016-12-07 18:28 ` Luis Machado
2016-12-08 12:16 ` Sturm, Michael
2016-12-08 15:35 ` Luis Machado
2017-01-26 14:29 ` Pedro Alves
2016-12-06 10:58 ` [PATCH v3 2/5] Change xstate_bv handling to use 8 bytes of data Michael Sturm
2017-01-26 14:46 ` Pedro Alves
2016-12-06 10:58 ` [PATCH v3 5/5] Add support for Intel PKRU register to GDB and GDBserver Michael Sturm
2016-12-08 15:35 ` Luis Machado
2017-01-26 15:38 ` Pedro Alves
2017-01-27 15:00 ` Sturm, Michael
2017-01-27 15:22 ` Pedro Alves [this message]
2017-02-01 12:34 ` Sturm, Michael
2016-12-06 10:59 ` [PATCH v3 4/5] Add target description for avx-avx512 Michael Sturm
2017-01-26 14:57 ` Pedro Alves
2017-01-26 16:02 ` Sturm, Michael
[not found] ` <DB865139DDA33A4DA36CC4A460C112734740AE54@irsmsx105.ger.corp.intel.com>
2017-01-26 14:07 ` [PING][PATCH v3 0/5] Add support for PKRU register to GDB and GDBServer Sturm, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8efd1e4f-47f9-8fe6-6db9-b6824970d91d@redhat.com \
--to=palves@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=michael.sturm@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox