Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Sturm, Michael" <michael.sturm@intel.com>
To: Luis Machado <lgustavo@codesourcery.com>,
	mark.kettenis@xs4all.nl, palves@redhat.com, eliz@gnu.org
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 1/5] Sync up x86-gcc-cpuid.h with cpuid.h from gcc-6 branch.
Date: Thu, 08 Dec 2016 12:16:00 -0000	[thread overview]
Message-ID: <58494F21.3090608@intel.com> (raw)
In-Reply-To: <06078318-8224-ee26-553e-42fe34305124@codesourcery.com>

Hello Luis,

there are two comment sections at the beginning of this file. I've 
updated the gcc version in the first one. The second one
is the copyright notice. It is unchanged from what is in mainline, which 
I think is how it should be.
In the diff, there is only the opening /* as context at the end of the 
first hunk.

So I think the patch is good to go...please let me know if you're after 
something else.

Thanks and Regards,
Michael

On 07/12/2016 19:28, Luis Machado wrote:
> On 12/06/2016 04:58 AM, Michael Sturm wrote:
>> Pedro suggested a separate patch synching with GCCs cpuid.h
>> instead of just adding new bits for PKU feature.
>>
>>  gdb/Changelog:
>>      2016-11-14  Michael Sturm  <michael.sturm@intel.com>
>>
>>           * nat/x86-gcc-cpuid.h: Replace with copy of cpuid.h
>>             from gcc-6 branch.
>>
>> Change-Id: I16f8f7f2d0aa7c2e815701d15ed831a6c6b33d21
>> Signed-off-by: Michael Sturm <michael.sturm@intel.com>
>> ---
>>  gdb/nat/x86-gcc-cpuid.h | 108 
>> ++++++++++++++++++++++--------------------------
>>  1 file changed, 50 insertions(+), 58 deletions(-)
>>
>> diff --git a/gdb/nat/x86-gcc-cpuid.h b/gdb/nat/x86-gcc-cpuid.h
>> index 1045521..5969b88 100644
>> --- a/gdb/nat/x86-gcc-cpuid.h
>> +++ b/gdb/nat/x86-gcc-cpuid.h
>> @@ -1,5 +1,5 @@
>>  /*
>> - * Helper cpuid.h file copied from gcc-4.8.0.  Code in gdb should not
>> + * Helper cpuid.h file copied from gcc-6.0.0.  Code in gdb should not
>>   * include this directly, but pull in x86-cpuid.h and use that func.
>>   */
>
> Copyright notice is still missing.

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


  reply	other threads:[~2016-12-08 12:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-06 10:58 [PATCH v3 0/5] Add support for PKRU register to GDB and GDBServer Michael Sturm
2016-12-06 10:58 ` [PATCH v3 5/5] Add support for Intel PKRU register to GDB and GDBserver Michael Sturm
2016-12-08 15:35   ` Luis Machado
2017-01-26 15:38   ` Pedro Alves
2017-01-27 15:00     ` Sturm, Michael
2017-01-27 15:22       ` Pedro Alves
2017-02-01 12:34         ` Sturm, Michael
2016-12-06 10:58 ` [PATCH v3 2/5] Change xstate_bv handling to use 8 bytes of data Michael Sturm
2017-01-26 14:46   ` Pedro Alves
2016-12-06 10:58 ` [PATCH v3 1/5] Sync up x86-gcc-cpuid.h with cpuid.h from gcc-6 branch Michael Sturm
2016-12-07 18:28   ` Luis Machado
2016-12-08 12:16     ` Sturm, Michael [this message]
2016-12-08 15:35       ` Luis Machado
2017-01-26 14:29   ` Pedro Alves
2016-12-06 10:58 ` [PATCH v3 3/5] Rename target descriptions to reflect actual content of description Michael Sturm
2017-01-26 14:50   ` Pedro Alves
2017-01-26 15:55     ` Sturm, Michael
2017-01-26 16:17       ` Pedro Alves
2016-12-06 10:59 ` [PATCH v3 4/5] Add target description for avx-avx512 Michael Sturm
2017-01-26 14:57   ` Pedro Alves
2017-01-26 16:02     ` Sturm, Michael
     [not found] ` <DB865139DDA33A4DA36CC4A460C112734740AE54@irsmsx105.ger.corp.intel.com>
2017-01-26 14:07   ` [PING][PATCH v3 0/5] Add support for PKRU register to GDB and GDBServer Sturm, Michael

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58494F21.3090608@intel.com \
    --to=michael.sturm@intel.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=lgustavo@codesourcery.com \
    --cc=mark.kettenis@xs4all.nl \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox