From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91291 invoked by alias); 8 Dec 2016 12:16:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91272 invoked by uid 89); 8 Dec 2016 12:16:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=gmbh, GmbH, H*r:sk:orsmga1, H*RU:HELO X-HELO: mga06.intel.com Received: from mga06.intel.com (HELO mga06.intel.com) (134.134.136.31) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Dec 2016 12:16:37 +0000 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP; 08 Dec 2016 04:16:35 -0800 X-ExtLoop1: 1 Received: from msturm-mobl2.ger.corp.intel.com (HELO [172.28.205.54]) ([172.28.205.54]) by FMSMGA003.fm.intel.com with ESMTP; 08 Dec 2016 04:16:33 -0800 Subject: Re: [PATCH v3 1/5] Sync up x86-gcc-cpuid.h with cpuid.h from gcc-6 branch. To: Luis Machado , mark.kettenis@xs4all.nl, palves@redhat.com, eliz@gnu.org References: <1481021894-29471-1-git-send-email-michael.sturm@intel.com> <1481021894-29471-2-git-send-email-michael.sturm@intel.com> <06078318-8224-ee26-553e-42fe34305124@codesourcery.com> Cc: gdb-patches@sourceware.org From: "Sturm, Michael" Message-ID: <58494F21.3090608@intel.com> Date: Thu, 08 Dec 2016 12:16:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <06078318-8224-ee26-553e-42fe34305124@codesourcery.com> Content-Type: text/plain; charset="windows-1252"; format="flowed" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2016-12/txt/msg00208.txt.bz2 Hello Luis, there are two comment sections at the beginning of this file. I've=20 updated the gcc version in the first one. The second one is the copyright notice. It is unchanged from what is in mainline, which=20 I think is how it should be. In the diff, there is only the opening /* as context at the end of the=20 first hunk. So I think the patch is good to go...please let me know if you're after=20 something else. Thanks and Regards, Michael On 07/12/2016 19:28, Luis Machado wrote: > On 12/06/2016 04:58 AM, Michael Sturm wrote: >> Pedro suggested a separate patch synching with GCCs cpuid.h >> instead of just adding new bits for PKU feature. >> >> gdb/Changelog: >> 2016-11-14 Michael Sturm >> >> * nat/x86-gcc-cpuid.h: Replace with copy of cpuid.h >> from gcc-6 branch. >> >> Change-Id: I16f8f7f2d0aa7c2e815701d15ed831a6c6b33d21 >> Signed-off-by: Michael Sturm >> --- >> gdb/nat/x86-gcc-cpuid.h | 108=20 >> ++++++++++++++++++++++-------------------------- >> 1 file changed, 50 insertions(+), 58 deletions(-) >> >> diff --git a/gdb/nat/x86-gcc-cpuid.h b/gdb/nat/x86-gcc-cpuid.h >> index 1045521..5969b88 100644 >> --- a/gdb/nat/x86-gcc-cpuid.h >> +++ b/gdb/nat/x86-gcc-cpuid.h >> @@ -1,5 +1,5 @@ >> /* >> - * Helper cpuid.h file copied from gcc-4.8.0. Code in gdb should not >> + * Helper cpuid.h file copied from gcc-6.0.0. Code in gdb should not >> * include this directly, but pull in x86-cpuid.h and use that func. >> */ > > Copyright notice is still missing. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928