From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95504 invoked by alias); 27 Jan 2017 15:22:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95489 invoked by uid 89); 27 Jan 2017 15:22:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=boards, H*i:sk:588B607, H*f:sk:588B607, H*MI:sk:588B607 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Jan 2017 15:22:11 +0000 Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 142C18123D; Fri, 27 Jan 2017 15:22:11 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id C664420CA97; Fri, 27 Jan 2017 15:22:08 +0000 (UTC) Subject: Re: [PATCH v3 5/5] Add support for Intel PKRU register to GDB and GDBserver. To: "Sturm, Michael" , mark.kettenis@xs4all.nl, eliz@gnu.org References: <1481021894-29471-1-git-send-email-michael.sturm@intel.com> <1481021894-29471-6-git-send-email-michael.sturm@intel.com> <588B607A.9040507@intel.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <8efd1e4f-47f9-8fe6-6db9-b6824970d91d@redhat.com> Date: Fri, 27 Jan 2017 15:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <588B607A.9040507@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-01/txt/msg00628.txt.bz2 On 01/27/2017 03:00 PM, Sturm, Michael wrote: >> In the test: >> >>> +#include >> This is not needed, right? > It's needed to pull in the definition for NULL which is used in the call > to __get_cpuid_ Ah. Could you include stddef.h instead? We avoid using stdio in tests unless required for the specifics of the test, in order to be able to run as most tests as possible against remote targets that don't support remote I/O (which are most, though the local gdbserver testing boards nowadays work around it). Just #including without relying on printf etc. itself is probably not really problematic anywhere, but it's a good proxy for identifying tests that wouldn't/shouldn't work in such targets. Thanks, Pedro Alves