From: Keith Seitz <keiths@redhat.com>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Make "list ambiguous" show symbol names too
Date: Wed, 06 Sep 2017 18:43:00 -0000 [thread overview]
Message-ID: <8e7b55b5-0249-405c-0041-c2fd73da732e@redhat.com> (raw)
In-Reply-To: <1504550858-27936-3-git-send-email-palves@redhat.com>
On 09/04/2017 11:47 AM, Pedro Alves wrote:
>
> Fix that by storing a pointer to the symbol in the sal.
:-)
> gdb/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * cli/cli-cmds.c (list_command): Use print_sal_location.
> (print_sal_location): New function.
> (ambiguous_line_spec): Use print_sal_location.
> * linespec.c (symbol_to_sal): Record the symbol in the sal.
> * symtab.c (find_function_start_sal): Likewise.
> * symtab.h (symtab_and_line::symbol): New field.
>
> gdb/testsuite/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * gdb.base/list-ambiguous.exp (test_list_ambiguous_symbol): Expect
> symbol names in gdb's output.
> * gdb.cp/overload.exp ("list all overloads"): Likewise.
FWIW, I looked this over and didn't see any problems.
Keith
next prev parent reply other threads:[~2017-09-06 18:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 18:47 [PATCH 0/2] " Pedro Alves
2017-09-04 18:47 ` [PATCH 2/2] " Pedro Alves
2017-09-06 18:43 ` Keith Seitz [this message]
2017-09-04 18:47 ` [PATCH 1/2] Fix "list ambiguous_variable" Pedro Alves
2017-09-06 18:41 ` Keith Seitz
2017-09-20 15:25 ` Pedro Alves
2017-10-16 15:03 ` Simon Marchi
2017-11-25 7:40 ` ppc64 regression: " Jan Kratochvil
2017-11-26 16:38 ` Ulrich Weigand
2017-11-29 19:08 ` [PATCH] Fix setting-breakpoints regression on PPC64 (function descriptors) (was: Re: ppc64 regression: [PATCH 1/2] Fix "list ambiguous_variable") Pedro Alves
2017-11-29 19:20 ` [PATCH] Fix setting-breakpoints regression on PPC64 (function descriptors) (was: Re: ppc64 regression: [PATCH 1/2] Fix "list amb Ulrich Weigand
2017-11-29 19:28 ` Pedro Alves
2017-12-08 9:44 ` [PATCH] Fix setting-breakpoints regression on PPC64 (function descriptors) Yao Qi
2017-12-08 11:34 ` Pedro Alves
2017-12-08 16:57 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e7b55b5-0249-405c-0041-c2fd73da732e@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox